Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: Source/bindings/scripts/idl_compiler.py

Issue 178003010: Make an IdlCompiler class (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/idl_compiler.py
diff --git a/Source/bindings/scripts/idl_compiler.py b/Source/bindings/scripts/idl_compiler.py
index 90f304da33a4e589a7615d9d8b404a393a1ba7ae..be9daf727e2b1336edbb53688f400fe932dac408 100755
--- a/Source/bindings/scripts/idl_compiler.py
+++ b/Source/bindings/scripts/idl_compiler.py
@@ -75,12 +75,30 @@ def write_file(new_text, destination_filename, only_if_changed):
destination_file.write(new_text)
+class IdlCompiler(object):
+ def __init__(self, output_directory, interfaces_info, idl_attributes_file, only_if_changed=False):
+ self.output_directory = output_directory
+ self.only_if_changed = only_if_changed
+ self.reader = IdlReader(interfaces_info, idl_attributes_file, output_directory)
+ self.code_generator = CodeGeneratorV8(interfaces_info, output_directory)
+
+ def compile(self, idl_filename):
+ basename = os.path.basename(idl_filename)
+ interface_name, _ = os.path.splitext(basename)
+
+ definitions = self.reader.read_idl_definitions(idl_filename)
+ header_text, cpp_text = self.code_generator.generate_code(definitions, interface_name)
+
+ header_filename = os.path.join(self.output_directory,
+ 'V8%s.h' % interface_name)
+ cpp_filename = os.path.join(self.output_directory,
+ 'V8%s.cpp' % interface_name)
+ write_file(header_text, header_filename, self.only_if_changed)
+ write_file(cpp_text, cpp_filename, self.only_if_changed)
+
+
def main():
options, idl_filename = parse_options()
- basename = os.path.basename(idl_filename)
- interface_name, _ = os.path.splitext(basename)
- output_directory = options.output_directory
- only_if_changed = options.write_file_only_if_changed
interfaces_info_filename = options.interfaces_info_file
if interfaces_info_filename:
@@ -89,17 +107,11 @@ def main():
else:
interfaces_info = None
- reader = IdlReader(interfaces_info, options.idl_attributes_file, output_directory)
- definitions = reader.read_idl_definitions(idl_filename)
-
- code_generator = CodeGeneratorV8(interfaces_info, output_directory)
- header_text, cpp_text = code_generator.generate_code(definitions, interface_name)
-
- header_filename = os.path.join(output_directory, 'V8%s.h' % interface_name)
- cpp_filename = os.path.join(output_directory, 'V8%s.cpp' % interface_name)
- write_file(header_text, header_filename, only_if_changed)
- write_file(cpp_text, cpp_filename, only_if_changed)
-
+ idl_compiler = IdlCompiler(options.output_directory,
+ interfaces_info,
+ options.idl_attributes_file,
+ options.write_file_only_if_changed)
+ idl_compiler.compile(idl_filename)
if __name__ == '__main__':
sys.exit(main())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698