Remove CanvasRenderingContext from the web exposed objects

Remove CanvasRenderingContext from the web exposed objects

We used have a shared super class called CanvasRenderingContext for
CanvasRenderingContext2D and WebGLRenderingContext. This does not
match the spec and it does not match Firefox or IE.

This removes the web exposed idl file for CanvasRenderingContext. The
method that used to return a CanvasRenderingContext now return a
(CanvasRenderingContext2D or WebGLRenderingContext) instead.

This also allows us to remove the custom bindings that was needed for
CanvasRenderingContext

This is a web exposed visible change. CanvasRenderingContext was
discoverable by walking the prototype chain. It was never exposed as a
named property of Window.

BUG=348012
R=ch.dumez@samsung.com, kbr@chromium.org, tkent@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=2cda866

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168488

[arv (Not doing code reviews), 2014-02-28 22:41:32]

PTAL

https://codereview.chromium.org/177983005/diff/1/Source/core/html/canvas/Canv...
File Source/core/html/canvas/CanvasRenderingContext2D.idl (right):

https://codereview.chromium.org/177983005/diff/1/Source/core/html/canvas/Canv...
Source/core/html/canvas/CanvasRenderingContext2D.idl:30: readonly attribute
HTMLCanvasElement canvas;
The spec puts this here. This used to be the only member of
CanvasRenderingContext.idl

[Inactive, 2014-02-28 23:27:09]

https://codereview.chromium.org/177983005/diff/1/Source/core/html/canvas/Canv...
File Source/core/html/canvas/CanvasRenderingContext.cpp (left):

https://codereview.chromium.org/177983005/diff/1/Source/core/html/canvas/Canv...
Source/core/html/canvas/CanvasRenderingContext.cpp:40:
ScriptWrappable::init(this);
I believe this should be moved to the 2 subclasses. I see that the 2 subclasses
now inherit ScriptWrappable but I don't think you moved this part?

[Inactive, 2014-02-28 23:32:15]

lgtm. I do believe the compatibility risk is low but an API OWNER needs to
approve.

https://codereview.chromium.org/177983005/diff/1/Source/core/html/canvas/Canv...
File Source/core/html/canvas/CanvasRenderingContext.cpp (left):

https://codereview.chromium.org/177983005/diff/1/Source/core/html/canvas/Canv...
Source/core/html/canvas/CanvasRenderingContext.cpp:40:
ScriptWrappable::init(this);
On 2014/02/28 23:27:09, Chris Dumez wrote:
> I believe this should be moved to the 2 subclasses. I see that the 2
subclasses
> now inherit ScriptWrappable but I don't think you moved this part?

Hmm, never mind, it was already there, which is why I don't see it in this
patch.

[Stephen White, 2014-02-28 23:36:40]

Seems reasonable to me (spec willing); leaving for Justin.

https://codereview.chromium.org/177983005/diff/1/Source/core/dom/Document.cpp
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/177983005/diff/1/Source/core/dom/Document.cpp...
Source/core/dom/Document.cpp:4726: context3d = toWebGLRenderingContext(context);
Wow.. I'd never even thought of trying WebGL as a CSS background. Who knows if
that works.

(This whole feature is a dhyatt special, and has no spec that I know of. We
should probably remove it at some point.)

[Rik, 2014-02-28 23:59:36]

On 2014/02/28 23:36:40, Stephen White wrote:
> Seems reasonable to me (spec willing); leaving for Justin.
> 
> https://codereview.chromium.org/177983005/diff/1/Source/core/dom/Document.cpp
> File Source/core/dom/Document.cpp (right):
> 
>
https://codereview.chromium.org/177983005/diff/1/Source/core/dom/Document.cpp...
> Source/core/dom/Document.cpp:4726: context3d =
toWebGLRenderingContext(context);
> Wow.. I'd never even thought of trying WebGL as a CSS background. Who knows if
> that works.
> 
> (This whole feature is a dhyatt special, and has no spec that I know of. We
> should probably remove it at some point.)

I think we want to standardize it :-)
It allows for some nice effects.

[arv (Not doing code reviews), 2014-03-01 02:16:49]

There is an alternative proposal (element). Once we have that we should
look into removing this.
On Feb 28, 2014 6:59 PM, <cabanier@adobe.com> wrote:

> On 2014/02/28 23:36:40, Stephen White wrote:
>
>> Seems reasonable to me (spec willing); leaving for Justin.
>>
>
>  https://codereview.chromium.org/177983005/diff/1/Source/
>> core/dom/Document.cpp
>> File Source/core/dom/Document.cpp (right):
>>
>
>
> https://codereview.chromium.org/177983005/diff/1/Source/
> core/dom/Document.cpp#newcode4726
>
>> Source/core/dom/Document.cpp:4726: context3d =
>>
> toWebGLRenderingContext(context);
>
>> Wow.. I'd never even thought of trying WebGL as a CSS background. Who
>> knows if
>> that works.
>>
>
>  (This whole feature is a dhyatt special, and has no spec that I know of.
>> We
>> should probably remove it at some point.)
>>
>
> I think we want to standardize it :-)
> It allows for some nice effects.
>
> https://codereview.chromium.org/177983005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[abarth-chromium, 2014-03-01 07:06:40]

On 2014/02/28 23:32:15, Chris Dumez wrote:
> lgtm. I do believe the compatibility risk is low but an API OWNER needs to
> approve.

IMHO, this qualifies as a trivial change, so you don't need a review from an API
owner.

[tkent, 2014-03-03 01:35:42]

public API change LGTM

[arv (Not doing code reviews), 2014-03-03 15:00:35]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2014-03-03 15:00:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/177983005/1

[Justin Novosad, 2014-03-03 16:12:45]

On 2014/02/28 23:36:40, Stephen White wrote:
> Seems reasonable to me (spec willing); leaving for Justin.

lgtm

> 
> https://codereview.chromium.org/177983005/diff/1/Source/core/dom/Document.cpp
> File Source/core/dom/Document.cpp (right):
> 
>
https://codereview.chromium.org/177983005/diff/1/Source/core/dom/Document.cpp...
> Source/core/dom/Document.cpp:4726: context3d =
toWebGLRenderingContext(context);
> Wow.. I'd never even thought of trying WebGL as a CSS background. Who knows if
> that works.
> 
Yeah, we should put a UMA counter on it.

[commit-bot: I haz the power, 2014-03-03 20:01:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-03 20:01:56]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[arv (Not doing code reviews), 2014-03-03 23:27:53]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2014-03-03 23:28:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/177983005/50001

[Ken Russell (switch to Gerrit), 2014-03-04 03:47:46]

LGTM FWIW

[arv (Not doing code reviews), 2014-03-04 22:46:36]

Committed patchset #4 manually as r2cda866 (presubmit successful).

[arv (Not doing code reviews), 2014-03-05 15:32:23]

On 2014/03/04 22:46:36, arv wrote:
> Committed patchset #4 manually as r2cda866 (presubmit successful).

This never landed... git cl push instead of git cl dcommit...

[arv (Not doing code reviews), 2014-03-05 15:34:45]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2014-03-05 15:34:46]

The CQ bit was unchecked by arv@chromium.org

[arv (Not doing code reviews), 2014-03-05 15:44:55]

Committed patchset #4 manually as r168488 (presubmit successful).