extensions/browser/api/vpn_provider/vpn_service.cc - Issue 1779633002: Invoke createNetwork() callback with GUID, not service name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/vpn_provider/vpn_service.cc

Issue 1779633002: Invoke createNetwork() callback with GUID, not service name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pass both service_path and guid arguments to all callbacks Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/networking_private/networking_private_service_client.h ('K') | « extensions/browser/api/vpn_provider/vpn_service.h ('k') | ui/chromeos/network/network_connect.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/vpn_provider/vpn_service.cc

diff --git a/extensions/browser/api/vpn_provider/vpn_service.cc b/extensions/browser/api/vpn_provider/vpn_service.cc

index 1214a3b89a7af02a9eb5d4aee8146513d78af9d4..7293f7072a5a67628cc728d6e2beffd6dcac39f8 100644

--- a/extensions/browser/api/vpn_provider/vpn_service.cc

+++ b/extensions/browser/api/vpn_provider/vpn_service.cc

@@ -494,7 +494,8 @@ void VpnService::OnExtensionUnloaded(

void VpnService::OnCreateConfigurationSuccess(

const VpnService::SuccessCallback& callback,

VpnConfiguration* configuration,

- const std::string& service_path) {

+ const std::string& service_path,

+ const std::string& guid) {

configuration->set_service_path(service_path);

service_path_to_configuration_map_[service_path] = configuration;

shill_client_->AddShillThirdPartyVpnObserver(configuration->object_path(),