extensions/browser/api/networking_private/networking_private_service_client.h - Issue 1779633002: Invoke createNetwork() callback with GUID, not service name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_private/networking_private_service_client.h

Issue 1779633002: Invoke createNetwork() callback with GUID, not service name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pass both service_path and guid arguments to all callbacks Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/networking_private/networking_private_delegate.h ('K') | « extensions/browser/api/networking_private/networking_private_linux.cc ('k') | extensions/browser/api/vpn_provider/vpn_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_private/networking_private_service_client.h

diff --git a/extensions/browser/api/networking_private/networking_private_service_client.h b/extensions/browser/api/networking_private/networking_private_service_client.h

index 63805db98a2af2a368258208008bb09f2f84c02c..89de608f7ca5a22c4345faccf3fb109bce1d4a82 100644

--- a/extensions/browser/api/networking_private/networking_private_service_client.h

+++ b/extensions/browser/api/networking_private/networking_private_service_client.h

@@ -65,7 +65,7 @@ class NetworkingPrivateServiceClient

const FailureCallback& failure_callback) override;

void CreateNetwork(bool shared,

scoped_ptr<base::DictionaryValue> properties_dict,

- const StringCallback& success_callback,

+ const ServiceCallback& success_callback,

const FailureCallback& failure_callback) override;

stevenjb 2016/03/10 01:49:10 This will almost certainly break on Windows.

Kevin Cernekee 2016/03/11 01:53:57 Done.

void ForgetNetwork(const std::string& guid,

const VoidCallback& success_callback,