Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: extensions/browser/api/networking_private/networking_private_service_client.h

Issue 1779633002: Invoke createNetwork() callback with GUID, not service name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pass both service_path and guid arguments to all callbacks Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_API_NETWORKING_PRIVATE_NETWORKING_PRIVATE_SERVICE_CLI ENT_H_ 5 #ifndef EXTENSIONS_BROWSER_API_NETWORKING_PRIVATE_NETWORKING_PRIVATE_SERVICE_CLI ENT_H_
6 #define EXTENSIONS_BROWSER_API_NETWORKING_PRIVATE_NETWORKING_PRIVATE_SERVICE_CLI ENT_H_ 6 #define EXTENSIONS_BROWSER_API_NETWORKING_PRIVATE_NETWORKING_PRIVATE_SERVICE_CLI ENT_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 const FailureCallback& failure_callback) override; 58 const FailureCallback& failure_callback) override;
59 void GetState(const std::string& guid, 59 void GetState(const std::string& guid,
60 const DictionaryCallback& success_callback, 60 const DictionaryCallback& success_callback,
61 const FailureCallback& failure_callback) override; 61 const FailureCallback& failure_callback) override;
62 void SetProperties(const std::string& guid, 62 void SetProperties(const std::string& guid,
63 scoped_ptr<base::DictionaryValue> properties_dict, 63 scoped_ptr<base::DictionaryValue> properties_dict,
64 const VoidCallback& success_callback, 64 const VoidCallback& success_callback,
65 const FailureCallback& failure_callback) override; 65 const FailureCallback& failure_callback) override;
66 void CreateNetwork(bool shared, 66 void CreateNetwork(bool shared,
67 scoped_ptr<base::DictionaryValue> properties_dict, 67 scoped_ptr<base::DictionaryValue> properties_dict,
68 const StringCallback& success_callback, 68 const ServiceCallback& success_callback,
69 const FailureCallback& failure_callback) override; 69 const FailureCallback& failure_callback) override;
stevenjb 2016/03/10 01:49:10 This will almost certainly break on Windows.
Kevin Cernekee 2016/03/11 01:53:57 Done.
70 void ForgetNetwork(const std::string& guid, 70 void ForgetNetwork(const std::string& guid,
71 const VoidCallback& success_callback, 71 const VoidCallback& success_callback,
72 const FailureCallback& failure_callback) override; 72 const FailureCallback& failure_callback) override;
73 void GetNetworks(const std::string& network_type, 73 void GetNetworks(const std::string& network_type,
74 bool configured_only, 74 bool configured_only,
75 bool visible_only, 75 bool visible_only,
76 int limit, 76 int limit,
77 const NetworkListCallback& success_callback, 77 const NetworkListCallback& success_callback,
78 const FailureCallback& failure_callback) override; 78 const FailureCallback& failure_callback) override;
79 void StartConnect(const std::string& guid, 79 void StartConnect(const std::string& guid,
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 scoped_refptr<base::SequencedTaskRunner> task_runner_; 179 scoped_refptr<base::SequencedTaskRunner> task_runner_;
180 // Use WeakPtrs for callbacks from |wifi_service_|. 180 // Use WeakPtrs for callbacks from |wifi_service_|.
181 base::WeakPtrFactory<NetworkingPrivateServiceClient> weak_factory_; 181 base::WeakPtrFactory<NetworkingPrivateServiceClient> weak_factory_;
182 182
183 DISALLOW_COPY_AND_ASSIGN(NetworkingPrivateServiceClient); 183 DISALLOW_COPY_AND_ASSIGN(NetworkingPrivateServiceClient);
184 }; 184 };
185 185
186 } // namespace extensions 186 } // namespace extensions
187 187
188 #endif // EXTENSIONS_BROWSER_API_NETWORKING_PRIVATE_NETWORKING_PRIVATE_SERVICE_ CLIENT_H_ 188 #endif // EXTENSIONS_BROWSER_API_NETWORKING_PRIVATE_NETWORKING_PRIVATE_SERVICE_ CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698