Remove Blink's DatabaseIdentifier implementation

third_party/WebKit/public/platform/Platform.h

Index: third_party/WebKit/public/platform/Platform.h
diff --git a/third_party/WebKit/public/platform/Platform.h b/third_party/WebKit/public/platform/Platform.h
index 880be7b063edc55f15fe453926130453695af9d3..c5f3636e98b00abf062e24243f6017d6bba0f0e7 100644
--- a/third_party/WebKit/public/platform/Platform.h
+++ b/third_party/WebKit/public/platform/Platform.h
@@ -205,11 +205,13 @@ public:
     virtual long long databaseGetFileSize(const WebString& vfsFileName) { return 0; }
 
     // Returns the space available for the given origin
-    virtual long long databaseGetSpaceAvailableForOrigin(const WebString& originIdentifier) { return 0; }
+    virtual long long databaseGetSpaceAvailableForOrigin(const WebSecurityOrigin& origin) { return 0; }
 
     // Set the size of the given database file
     virtual bool databaseSetFileSize(const WebString& vfsFileName, long long size) { return false; }
 
+    // Return a filename-friendly identifier for an origin.
+    virtual WebString databaseCreateOriginIdentifier(const WebSecurityOrigin& origin) { return WebString(); }

[michaeln, 2016/03/12 00:33:38]

the android webview test harness probably has another Platform derivative that
needs to override the method

[jsbell, 2016/03/14 22:30:59]

Not quite that simple, alas. I'm not done debugging (it's a bit slow!) but
apparently in webview an invalid URL is being passed in, so Chromium's
DatabaseIdentifier::CreateFromOrigin() returns something different than what
Blink did.

[jsbell, 2016/03/16 16:40:08]

And continuing the investigation (didn't have much time yesterday) it a URL
where blink returns true for isLocal(). Hopefully it'll repro on desktop with
file: or something.

 
     // DOM Storage --------------------------------------------------
 
@@ -222,6 +224,8 @@ public:
     // Must return non-null.
     virtual WebFileSystem* fileSystem() { return nullptr; }
 
+    // Return a filename-friendly identifier for an origin.
+    virtual WebString fileSystemCreateOriginIdentifier(const WebSecurityOrigin& origin) { return WebString(); }
 
     // IDN conversion ------------------------------------------------------