Remove Blink's DatabaseIdentifier implementation

third_party/WebKit/public/platform/Platform.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 187 matching lines @@
     // Deletes a database file and returns the error code
     virtual int databaseDeleteFile(const WebString& vfsFileName, bool syncDir) { return 0; }
 
     // Returns the attributes of the given database file
     virtual long databaseGetFileAttributes(const WebString& vfsFileName) { return 0; }
 
     // Returns the size of the given database file
     virtual long long databaseGetFileSize(const WebString& vfsFileName) { return 0; }
 
     // Returns the space available for the given origin
-    virtual long long databaseGetSpaceAvailableForOrigin(const WebString& originIdentifier) { return 0; }
+    virtual long long databaseGetSpaceAvailableForOrigin(const WebSecurityOrigin& origin) { return 0; }
 
     // Set the size of the given database file
     virtual bool databaseSetFileSize(const WebString& vfsFileName, long long size) { return false; }
 
+    // Return a filename-friendly identifier for an origin.
+    virtual WebString databaseCreateOriginIdentifier(const WebSecurityOrigin& origin) { return WebString(); }

[michaeln, 2016/03/12 00:33:38]

the android webview test harness probably has another Platform derivative that
needs to override the method

[jsbell, 2016/03/14 22:30:59]

Not quite that simple, alas. I'm not done debugging (it's a bit slow!) but
apparently in webview an invalid URL is being passed in, so Chromium's
DatabaseIdentifier::CreateFromOrigin() returns something different than what
Blink did.

[jsbell, 2016/03/16 16:40:08]

And continuing the investigation (didn't have much time yesterday) it a URL
where blink returns true for isLocal(). Hopefully it'll repro on desktop with
file: or something.

 
     // DOM Storage --------------------------------------------------
 
     // Return a LocalStorage namespace
     virtual WebStorageNamespace* createLocalStorageNamespace() { return nullptr; }
 
 
     // FileSystem ----------------------------------------------------------
 
     // Must return non-null.
     virtual WebFileSystem* fileSystem() { return nullptr; }
 
+    // Return a filename-friendly identifier for an origin.
+    virtual WebString fileSystemCreateOriginIdentifier(const WebSecurityOrigin& origin) { return WebString(); }
 
     // IDN conversion ------------------------------------------------------
 
     virtual WebString convertIDNToUnicode(const WebString& host, const WebString& languages) { return host; }
 
 
     // IndexedDB ----------------------------------------------------------
 
     // Must return non-null.
     virtual WebIDBFactory* idbFactory() { return nullptr; }
@@ skipping 385 matching lines @@
 protected:
     Platform();
     virtual ~Platform() { }
 
     WebThread* m_mainThread;
 };
 
 } // namespace blink
 
 #endif