Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/browser/ui/views/mac/certificate_viewer_views_mac.h

Issue 1779383002: MacViews: Remove constrained window dependencies for certificate viewer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Position correctly (kind of) & block on tab only. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/mac/certificate_viewer_views_mac.h
diff --git a/chrome/browser/ui/views/mac/certificate_viewer_views_mac.h b/chrome/browser/ui/views/mac/certificate_viewer_views_mac.h
new file mode 100644
index 0000000000000000000000000000000000000000..2273e3f9aed2884519eba1d31bfc20a27d5c5e67
--- /dev/null
+++ b/chrome/browser/ui/views/mac/certificate_viewer_views_mac.h
@@ -0,0 +1,36 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
tapted 2016/03/21 02:47:13 nit: no (c)
Patti Lor 2016/05/03 00:05:00 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_MAC_CERTIFICATE_VIEWER_VIEWS_MAC_H_
tapted 2016/03/21 02:47:13 Let's keep it in chrome/browser/ui/cocoa/ for now
Patti Lor 2016/05/03 00:05:00 Done, but with .mm not .cc, is that what you meant
+
tapted 2016/03/21 02:47:13 remove blank line
Patti Lor 2016/05/03 00:05:00 Done.
+#define CHROME_BROWSER_UI_VIEWS_MAC_CERTIFICATE_VIEWER_VIEWS_MAC_H_
+
+#import "chrome/browser/mac/certificate_viewer_base.h"
+#import "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h"
tapted 2016/03/21 02:47:13 This protocol is inherited, so not needed here.
Patti Lor 2016/05/03 00:05:00 Done.
+#include "chrome/browser/ui/views/mac/web_contents_modal_dialog_manager_views_mac.h"
+
+
tapted 2016/03/21 02:47:13 remove blank line
Patti Lor 2016/05/03 00:05:00 Done.
+@interface SSLCertificateViewerViewsMac :
tapted 2016/03/21 02:47:13 needs a comments
Patti Lor 2016/05/03 00:05:00 Done.
+ SSLCertificateViewerMacBase<ConstrainedWindowSheet> {
tapted 2016/03/21 02:47:13 remove <ConstrainedWindowSheet>
Patti Lor 2016/05/03 00:05:00 Done.
+ @private
+ scoped_ptr<SingleWebContentsDialogManagerViewsMac> constrainedWindow_;
+ content::WebContents* webContents_;
+}
+
+- (void)displayForWebContents:(content::WebContents*)webContents;
+
+- (void)onParentWindowSizeDidChange:(NSNotification*)notification;
+
+- (void)observeValueForKeyPath:(NSString*)keyPath
+ ofObject:(id)object
+ change:(NSDictionary*)change
+ context:(void*)context;
+
+- (void)sheetDidEnd:(NSWindow*)parent
+ returnCode:(NSInteger)returnCode
+ context:(void*)context;
+
+@end
+
+#endif // CHROME_BROWSER_UI_VIEWS_MAC_CERTIFICATE_VIEWER_VIEWS_MAC_H_

Powered by Google App Engine
This is Rietveld 408576698