Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: chrome/browser/ui/views/mac/certificate_viewer_views_mac.h

Issue 1779383002: MacViews: Remove constrained window dependencies for certificate viewer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Position correctly (kind of) & block on tab only. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
tapted 2016/03/21 02:47:13 nit: no (c)
Patti Lor 2016/05/03 00:05:00 Done.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_UI_VIEWS_MAC_CERTIFICATE_VIEWER_VIEWS_MAC_H_
tapted 2016/03/21 02:47:13 Let's keep it in chrome/browser/ui/cocoa/ for now
Patti Lor 2016/05/03 00:05:00 Done, but with .mm not .cc, is that what you meant
6
tapted 2016/03/21 02:47:13 remove blank line
Patti Lor 2016/05/03 00:05:00 Done.
7 #define CHROME_BROWSER_UI_VIEWS_MAC_CERTIFICATE_VIEWER_VIEWS_MAC_H_
8
9 #import "chrome/browser/mac/certificate_viewer_base.h"
10 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h"
tapted 2016/03/21 02:47:13 This protocol is inherited, so not needed here.
Patti Lor 2016/05/03 00:05:00 Done.
11 #include "chrome/browser/ui/views/mac/web_contents_modal_dialog_manager_views_ma c.h"
12
13
tapted 2016/03/21 02:47:13 remove blank line
Patti Lor 2016/05/03 00:05:00 Done.
14 @interface SSLCertificateViewerViewsMac :
tapted 2016/03/21 02:47:13 needs a comments
Patti Lor 2016/05/03 00:05:00 Done.
15 SSLCertificateViewerMacBase<ConstrainedWindowSheet> {
tapted 2016/03/21 02:47:13 remove <ConstrainedWindowSheet>
Patti Lor 2016/05/03 00:05:00 Done.
16 @private
17 scoped_ptr<SingleWebContentsDialogManagerViewsMac> constrainedWindow_;
18 content::WebContents* webContents_;
19 }
20
21 - (void)displayForWebContents:(content::WebContents*)webContents;
22
23 - (void)onParentWindowSizeDidChange:(NSNotification*)notification;
24
25 - (void)observeValueForKeyPath:(NSString*)keyPath
26 ofObject:(id)object
27 change:(NSDictionary*)change
28 context:(void*)context;
29
30 - (void)sheetDidEnd:(NSWindow*)parent
31 returnCode:(NSInteger)returnCode
32 context:(void*)context;
33
34 @end
35
36 #endif // CHROME_BROWSER_UI_VIEWS_MAC_CERTIFICATE_VIEWER_VIEWS_MAC_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698