Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1779373002: Revert removal of TypedArray constructor optimization (Closed)

Created:
4 years, 9 months ago by Dan Ehrenberg
Modified:
4 years, 9 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert removal of TypedArray constructor optimization When the TypedArray iterator constructor code path was added, a technically incorrect optimization was added which uses the arraylike code path on array arguments, even though the %ArrayIterator% could have been monkey-patched to give different behavior. A previous patch removed this optimization, and this patch restores it due to the huge performance regression that resulted. The optimization was previously removed in https://codereview.chromium.org/1767893002 BUG=chromium:593644 R=adamk LOG=Y Committed: https://crrev.com/5f5c48da64ba6ac91f73b812ff41a36285d629e3 Cr-Commit-Position: refs/heads/master@{#34697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/js/typedarray.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779373002/1
4 years, 9 months ago (2016-03-10 22:12:51 UTC) #3
Dan Ehrenberg
4 years, 9 months ago (2016-03-10 23:04:08 UTC) #4
adamk
lgtm
4 years, 9 months ago (2016-03-10 23:11:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779373002/1
4 years, 9 months ago (2016-03-10 23:16:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 23:25:22 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 23:26:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f5c48da64ba6ac91f73b812ff41a36285d629e3
Cr-Commit-Position: refs/heads/master@{#34697}

Powered by Google App Engine
This is Rietveld 408576698