src/js/typedarray.js - Issue 1779373002: Revert removal of TypedArray constructor optimization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/typedarray.js

Issue 1779373002: Revert removal of TypedArray constructor optimization (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/typedarray.js

diff --git a/src/js/typedarray.js b/src/js/typedarray.js

index e3c02252e7eb752799473414a51d8f50fb76ee9a..b175b2c321e166aca4f8741c6f63246cc20d5c1d 100644

--- a/src/js/typedarray.js

+++ b/src/js/typedarray.js

@@ -270,7 +270,7 @@ function NAMEConstructor(arg1, arg2, arg3) {

NAMEConstructByTypedArray(this, arg1);

} else {

var iteratorFn = arg1[iteratorSymbol];

- if (IS_UNDEFINED(iteratorFn)) {

+ if (IS_UNDEFINED(iteratorFn) || iteratorFn === ArrayValues) {

NAMEConstructByArrayLike(this, arg1, arg1.length);

} else {

NAMEConstructByIterable(this, arg1, iteratorFn);

« no previous file with comments | « no previous file | no next file » | no next file with comments »