Store and use last base URL between DidStart / DidStopLoading

content/browser/frame_host/navigation_controller_impl.cc

Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index e24b58e84c6d09a62902022699c380921c95f04c..67f7d2edf796cbb62f1e11087f1e0359d0b5cb5b 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -1144,6 +1144,8 @@ void NavigationControllerImpl::RendererDidNavigateToNewPage(
   new_entry->SetURL(params.url);
   if (update_virtual_url)
     UpdateVirtualURLToURL(new_entry.get(), params.url);
+  if (params.url.SchemeIs(url::kDataScheme))
+    new_entry->SetBaseURLForDataURL(params.base_url);

[Charlie Reis, 2016/03/11 23:32:08]

This seems too broad.  We only use SetBaseURLForDataURL when using
loadDataFromBaseURL, not for all data: URLs.  We don't want to call
SetBaseURLForDataURL in normal data: URL navigations because there's other logic
that checks GetBaseURLForDataURL to distinguish between loadDataFromBaseURL and
normal data: URL navigations.

Can we narrow this to only apply in the loadDataFromBaseURL case?

   new_entry->SetReferrer(params.referrer);
   new_entry->SetPageID(params.page_id);
   new_entry->SetTransitionType(params.transition);