Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1934)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

Issue 1779363004: Store and use last base URL between DidStart / DidStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java
index 177f8c73e89ded668dae4aaa92e089c85ad3dbca..e9898da3bd24a4f6a494c7696a9fe6eec2900bc2 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java
@@ -373,4 +373,19 @@ public class LoadDataWithBaseUrlTest extends AwTestBase {
assertEquals("true", executeJavaScriptAndWaitForResult(mAwContents, mContentsClient,
"window.gotToEndOfBody"));
}
+
+ // See b/275348709.
+ @SmallTest
+ @Feature({"AndroidWebView"})
+ public void testOnPageFinishedWhenInterrupted() throws Throwable {
+ final String pageHtml = "<html><body>Hello, world!</body></html>";
+ final String baseUrl = "http://example.com/";
+ final TestCallbackHelperContainer.OnPageFinishedHelper onPageFinishedHelper =
+ mContentsClient.getOnPageFinishedHelper();
+ final int callCount = onPageFinishedHelper.getCallCount();
+ loadDataWithBaseUrlAsync(mAwContents, pageHtml, "text/html", false, baseUrl, null);
+ loadUrlAsync(mAwContents, "javascript:42");
+ onPageFinishedHelper.waitForCallback(callCount);
+ assertEquals(baseUrl, onPageFinishedHelper.getUrl());
+ }
}

Powered by Google App Engine
This is Rietveld 408576698