Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: base/win/scoped_handle_test_dll.h

Issue 1779333003: Add test for multithreaded ActiveVerifier behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@handlecreate
Patch Set: nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/win/scoped_handle_test_dll.h
diff --git a/base/win/scoped_handle_test_dll.h b/base/win/scoped_handle_test_dll.h
new file mode 100644
index 0000000000000000000000000000000000000000..f6126dd9a5d26e5e6bd40e3b2b01c510ca81bed1
--- /dev/null
+++ b/base/win/scoped_handle_test_dll.h
@@ -0,0 +1,26 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
scottmg 2016/03/11 19:02:18 No (c). https://www.chromium.org/developers/codin
Will Harris 2016/03/11 20:35:32 bah! I chose the wrong file to copy and paste. And
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_WIN_SCOPED_HANDLE_TEST_DLL_H_
+#define BASE_WIN_SCOPED_HANDLE_TEST_DLL_H_
+
+namespace base {
+namespace win {
+namespace testing {
+
+enum class Result {
scottmg 2016/03/11 19:02:18 base::win::testing::Result seems a bit too generic
Will Harris 2016/03/11 20:35:32 base::win::testing::ScopedHandleTestResult okay? I
+ SUCCESS = 0,
+ ERROR_COULD_NOT_CREATE_EVENT,
scottmg 2016/03/11 19:02:18 You also don't seem to be using the great expanse
Will Harris 2016/03/11 20:35:32 it's nice to know which error happened when it hap
+ ERROR_COULD_NOT_GET_HANDLE_VERIFIER_MODULE,
+ ERROR_COULD_NOT_GET_MY_MODULE,
+ ERROR_WRONG_MODULE
+};
+
+extern "C" Result __declspec(dllexport) RunTest();
+
+} // namespace testing
+} // namespace win
+} // namespace base
+
+#endif // BASE_WIN_SCOPED_HANDLE_TEST_DLL_H_

Powered by Google App Engine
This is Rietveld 408576698