Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Side by Side Diff: base/win/scoped_handle_test_dll.h

Issue 1779333003: Add test for multithreaded ActiveVerifier behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@handlecreate
Patch Set: nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
scottmg 2016/03/11 19:02:18 No (c). https://www.chromium.org/developers/codin
Will Harris 2016/03/11 20:35:32 bah! I chose the wrong file to copy and paste. And
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef BASE_WIN_SCOPED_HANDLE_TEST_DLL_H_
6 #define BASE_WIN_SCOPED_HANDLE_TEST_DLL_H_
7
8 namespace base {
9 namespace win {
10 namespace testing {
11
12 enum class Result {
scottmg 2016/03/11 19:02:18 base::win::testing::Result seems a bit too generic
Will Harris 2016/03/11 20:35:32 base::win::testing::ScopedHandleTestResult okay? I
13 SUCCESS = 0,
14 ERROR_COULD_NOT_CREATE_EVENT,
scottmg 2016/03/11 19:02:18 You also don't seem to be using the great expanse
Will Harris 2016/03/11 20:35:32 it's nice to know which error happened when it hap
15 ERROR_COULD_NOT_GET_HANDLE_VERIFIER_MODULE,
16 ERROR_COULD_NOT_GET_MY_MODULE,
17 ERROR_WRONG_MODULE
18 };
19
20 extern "C" Result __declspec(dllexport) RunTest();
21
22 } // namespace testing
23 } // namespace win
24 } // namespace base
25
26 #endif // BASE_WIN_SCOPED_HANDLE_TEST_DLL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698