base/win/scoped_handle.h - Issue 1779333003: Add test for multithreaded ActiveVerifier behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/win/scoped_handle.h

Issue 1779333003: Add test for multithreaded ActiveVerifier behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@handlecreate

Patch Set: nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/win/scoped_handle.h

diff --git a/base/win/scoped_handle.h b/base/win/scoped_handle.h

index ac01485ab53c2ca453bff6cef0e4b88a8b70d0da..ad8c792a4de686342a1436babd78b81626374637 100644

--- a/base/win/scoped_handle.h

+++ b/base/win/scoped_handle.h

@@ -179,6 +179,8 @@ void BASE_EXPORT DisableHandleVerifier();

// a CHECK is generated.

void BASE_EXPORT OnHandleBeingClosed(HANDLE handle);

+HMODULE BASE_EXPORT GetHandleVerifierModuleForTesting();

scottmg 2016/03/11 19:02:18 Could you put these BASE_EXPORTs before the return

scottmg 2016/03/11 19:02:18 Some sort of comment here.

Will Harris 2016/03/11 20:35:31 Done.

} // namespace win

} // namespace base

« no previous file with comments | « base/process/memory_win.cc ('k') | base/win/scoped_handle.cc » ('j') | base/win/scoped_handle.cc » ('J')