base/win/scoped_handle.h - Issue 1779333003: Add test for multithreaded ActiveVerifier behavior.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/win/scoped_handle.h

Issue 1779333003: Add test for multithreaded ActiveVerifier behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@handlecreate

Patch Set: nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BASE_WIN_SCOPED_HANDLE_H_	5 #ifndef BASE_WIN_SCOPED_HANDLE_H_

6 #define BASE_WIN_SCOPED_HANDLE_H_	6 #define BASE_WIN_SCOPED_HANDLE_H_

7	7

8 #include <windows.h>	8 #include <windows.h>

9	9

10 #include "base/base_export.h"	10 #include "base/base_export.h"

(...skipping 161 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
172 // VerifierTraits at runtime. It has no effect if DummyVerifierTraits is used	172 // VerifierTraits at runtime. It has no effect if DummyVerifierTraits is used

173 // for ScopedHandle.	173 // for ScopedHandle.

174 void BASE_EXPORT DisableHandleVerifier();	174 void BASE_EXPORT DisableHandleVerifier();

175	175

176 // This should be called whenever the OS is closing a handle, if extended	176 // This should be called whenever the OS is closing a handle, if extended

177 // verification of improper handle closing is desired. If \|handle\| is being	177 // verification of improper handle closing is desired. If \|handle\| is being

178 // tracked by the handle verifier and ScopedHandle is not the one closing it,	178 // tracked by the handle verifier and ScopedHandle is not the one closing it,

179 // a CHECK is generated.	179 // a CHECK is generated.

180 void BASE_EXPORT OnHandleBeingClosed(HANDLE handle);	180 void BASE_EXPORT OnHandleBeingClosed(HANDLE handle);

181	181

	182 HMODULE BASE_EXPORT GetHandleVerifierModuleForTesting();
	scottmg 2016/03/11 19:02:18 Could you put these BASE_EXPORTs before the return Could you put these BASE_EXPORTs before the return type like most files? scottmg 2016/03/11 19:02:18 Some sort of comment here. Some sort of comment here. Will Harris 2016/03/11 20:35:31 Done. Show quoted text On 2016/03/11 19:02:18, scottmg wrote: > Some sort of comment here. Done. Will Harris 2016/03/11 20:35:31 Done. Show quoted text On 2016/03/11 19:02:18, scottmg wrote: > Could you put these BASE_EXPORTs before the return type like most files? Done.
	183

182 } // namespace win	184 } // namespace win

183 } // namespace base	185 } // namespace base

184	186

185 #endif // BASE_WIN_SCOPED_HANDLE_H_	187 #endif // BASE_WIN_SCOPED_HANDLE_H_

OLD	NEW

« no previous file with comments | « base/process/memory_win.cc ('k') | base/win/scoped_handle.cc » ('j') | base/win/scoped_handle.cc » ('J')