Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Unified Diff: base/BUILD.gn

Issue 1779333003: Add test for multithreaded ActiveVerifier behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@handlecreate
Patch Set: nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base.gyp » ('j') | base/win/scoped_handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 925dd7a0d944e7ad3f8b3f4a4c01f79fc40bc889..747907ca5aadd4b389acc53d71c26aebcff0b94d 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1538,6 +1538,16 @@ if (is_win) {
]
}
+ shared_library("scoped_handle_test_dll") {
+ sources = [
+ "win/scoped_handle_test_dll.cc",
+ "win/scoped_handle_test_dll.h",
+ ]
+ deps = [
+ ":base",
+ ]
+ }
+
if (target_cpu == "x64") {
# Must be a shared library so that it can be unloaded during testing.
shared_library("base_profiler_test_support_library") {
@@ -1901,9 +1911,12 @@ test("base_unittests") {
set_sources_assignment_filter(sources_assignment_filter)
}
- if (is_win && target_cpu == "x64") {
- sources += [ "profiler/win32_stack_frame_unwinder_unittest.cc" ]
- deps += [ ":base_profiler_test_support_library" ]
+ if (is_win) {
+ deps += [ "//base:scoped_handle_test_dll" ]
+ if (target_cpu == "x64") {
+ sources += [ "profiler/win32_stack_frame_unwinder_unittest.cc" ]
+ deps += [ ":base_profiler_test_support_library" ]
+ }
}
if (use_experimental_allocator_shim) {
« no previous file with comments | « no previous file | base/base.gyp » ('j') | base/win/scoped_handle.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698