Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3776)

Unified Diff: base/base.gyp

Issue 1779333003: Add test for multithreaded ActiveVerifier behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@handlecreate
Patch Set: code review comments. fix a thread start race. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index 5b20cfec9fd86d45ac2248d87fb312ea1a00d6c1..c4ed5c7f3b1e448332b58eff9068d077cb985077 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -699,6 +699,9 @@
],
}],
['OS == "win"', {
+ 'dependencies': [
+ 'scoped_handle_test_dll'
Nico 2016/03/11 23:26:58 ...and in gyp you instead link base_unittests agai
Will Harris 2016/03/12 00:00:01 now it's a loadable_module it shouldn't do any kin
+ ],
'sources!': [
'file_descriptor_shuffle_unittest.cc',
'files/dir_reader_posix_unittest.cc',
@@ -1680,6 +1683,16 @@
},
},
},
+ {
+ 'target_name': 'scoped_handle_test_dll',
+ 'type': 'shared_library',
+ 'dependencies': [
+ 'base',
+ ],
+ 'sources': [
+ 'win/scoped_handle_test_dll.cc',
+ ],
+ },
],
}],
['test_isolation_mode != "noop"', {

Powered by Google App Engine
This is Rietveld 408576698