Chromium Code Reviews| Index: base/BUILD.gn |
| diff --git a/base/BUILD.gn b/base/BUILD.gn |
| index 0b41b0e4a8c93c766501839b81c576d5c8d3cdc9..39ee80417b95369cc3ecd133571b8ba9fbd2b23a 100644 |
| --- a/base/BUILD.gn |
| +++ b/base/BUILD.gn |
| @@ -1593,6 +1593,15 @@ if (is_win) { |
| ] |
| } |
| + shared_library("scoped_handle_test_dll") { |
| + sources = [ |
| + "win/scoped_handle_test_dll.cc", |
| + ] |
| + deps = [ |
| + ":base", |
|
Nico
2016/03/11 23:26:58
...you really want to link base into your test dll
Will Harris
2016/03/12 00:00:01
yes, because I need to test behavior of base's act
|
| + ] |
| + } |
| + |
| if (target_cpu == "x64") { |
| # Must be a shared library so that it can be unloaded during testing. |
| shared_library("base_profiler_test_support_library") { |
| @@ -1956,9 +1965,12 @@ test("base_unittests") { |
| set_sources_assignment_filter(sources_assignment_filter) |
| } |
| - if (is_win && target_cpu == "x64") { |
| - sources += [ "profiler/win32_stack_frame_unwinder_unittest.cc" ] |
| - deps += [ ":base_profiler_test_support_library" ] |
| + if (is_win) { |
| + deps += [ "//base:scoped_handle_test_dll" ] |
|
Nico
2016/03/11 23:26:58
is this a dll loaded by tests? does it need to be
Will Harris
2016/03/12 00:00:01
once I changed this to loadable_library then isola
|
| + if (target_cpu == "x64") { |
| + sources += [ "profiler/win32_stack_frame_unwinder_unittest.cc" ] |
| + deps += [ ":base_profiler_test_support_library" ] |
| + } |
| } |
| if (use_experimental_allocator_shim) { |