Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1779303002: [Android] Reenable document mode tests. (Closed)

Created:
4 years, 9 months ago by jbudorick
Modified:
4 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Reenable document mode tests. This reverts commit d65f3cc4524525f69e30ce6e6c71769ee44459ba and makes two WebappModeTests enable document mode. BUG=592404 Committed: https://crrev.com/5dbc89896ef3ed45ec4f2d7d761d53e6ba2dc60e Cr-Commit-Position: refs/heads/master@{#380854}

Patch Set 1 #

Total comments: 2

Patch Set 2 : tedchoc comment #

Messages

Total messages: 11 (4 generated)
jbudorick
these should be safe now that https://codereview.chromium.org/1761383002/ has landed.
4 years, 9 months ago (2016-03-10 20:17:04 UTC) #2
jbudorick
something something deck chairs ping
4 years, 9 months ago (2016-03-11 17:26:12 UTC) #3
Ted C
lgtm https://codereview.chromium.org/1779303002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java (right): https://codereview.chromium.org/1779303002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java#newcode261 chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java:261: boolean previouslyOptedOut = documentModeManager.isOptedOutOfDocumentMode(); a small comment about ...
4 years, 9 months ago (2016-03-11 17:35:51 UTC) #4
jbudorick
https://codereview.chromium.org/1779303002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java (right): https://codereview.chromium.org/1779303002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java#newcode261 chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java:261: boolean previouslyOptedOut = documentModeManager.isOptedOutOfDocumentMode(); On 2016/03/11 17:35:51, Ted C ...
4 years, 9 months ago (2016-03-12 02:13:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779303002/20001
4 years, 9 months ago (2016-03-12 02:14:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-12 04:51:29 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 04:52:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5dbc89896ef3ed45ec4f2d7d761d53e6ba2dc60e
Cr-Commit-Position: refs/heads/master@{#380854}

Powered by Google App Engine
This is Rietveld 408576698