Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/DocumentModeRecentlyClosedTest.java

Issue 1779303002: [Android] Reenable document mode tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tedchoc comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/DocumentModeRecentlyClosedTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/DocumentModeRecentlyClosedTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/DocumentModeRecentlyClosedTest.java
index 1cddfd8dd2a1487c7343be04aa313cfbf8562c61..c471f3e372ca471a861ad7b710bebce93481ce6a 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/DocumentModeRecentlyClosedTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/DocumentModeRecentlyClosedTest.java
@@ -6,10 +6,10 @@ package org.chromium.chrome.browser.ntp;
import android.app.Activity;
import android.os.Build;
+import android.test.suitebuilder.annotation.MediumTest;
import org.chromium.base.ApplicationStatus;
import org.chromium.base.ThreadUtils;
-import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.MinAndroidSdkLevel;
import org.chromium.chrome.browser.ChromeApplication;
import org.chromium.chrome.browser.document.DocumentActivity;
@@ -78,8 +78,7 @@ public class DocumentModeRecentlyClosedTest extends DocumentModeTestBase {
* recently closed. This test relies on mocking out the ActivityDelegate because we have no
* obvious way to simulate a user closing a Tab while Chrome is closed.
*/
- // @MediumTest
- @DisabledTest // https://crbug.com/592404
+ @MediumTest
public void testMissingTasksBecomeRecentlyClosed() throws Exception {
// Set up the DocumentTabModel so that it finds a task in Android's Recents that it doesn't
// know about, which results in adding the Tab to the DocumentTabModel.
@@ -133,8 +132,7 @@ public class DocumentModeRecentlyClosedTest extends DocumentModeTestBase {
}
/** Test that the "Recently closed" list is updated properly via the TabModel. */
- // @MediumTest
- @DisabledTest // https://crbug.com/592404
+ @MediumTest
public void testUpdateRecentlyClosedAfterTabModelClose() throws Exception {
int[] tabIds = launchThreeTabs();
@@ -206,8 +204,7 @@ public class DocumentModeRecentlyClosedTest extends DocumentModeTestBase {
/**
* Test that the "Recently closed" list is updated when Chrome is alive but backgrounded.
*/
- // @MediumTest
- @DisabledTest // https://crbug.com/592404
+ @MediumTest
public void testUpdateRecentlyClosedWhenChromeInBackground() throws Exception {
int[] tabIds = launchThreeTabs();

Powered by Google App Engine
This is Rietveld 408576698