Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1779233002: Fix for indexing synthetic elements. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -104 lines) Patch
M pkg/analysis_server/lib/src/services/index2/index2.dart View 1 chunk +5 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart View 2 chunks +12 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/search/search_engine2_test.dart View 2 chunks +28 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/summary/index_unit.dart View 10 chunks +91 lines, -78 lines 0 comments Download
M pkg/analyzer/test/src/summary/index_unit_test.dart View 3 chunks +31 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-10 18:23:55 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-10 18:55:11 UTC) #2
scheglov
4 years, 9 months ago (2016-03-10 18:57:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5271cd325974534cd450768f8cb19afed1bcb066 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698