Fix for indexing synthetic elements.

pkg/analyzer/test/src/summary/index_unit_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:convert';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/summary/format.dart';
 import 'package:analyzer/src/summary/idl.dart';
@@ skipping 374 matching lines @@
   A operator ~() => this;
 }
 main(A a) {
   print(~a);
 }
 ''');
     MethodElement element = findElement('~');
     assertThat(element).isInvokedAt('~a', true, length: 1);
   }
 
+  void test_isInvokedBy_PropertyAccessorElement_getter() {
+    _indexTestUnit('''
+class A {
+  get ggg => null;
+  main() {
+    this.ggg(); // q
+    ggg(); // nq
+  }
+}''');
+    PropertyAccessorElement element = findElement('ggg', ElementKind.GETTER);
+    assertThat(element)
+      ..isInvokedAt('ggg(); // q', true)
+      ..isInvokedAt('ggg(); // nq', false);
+  }
+
   void test_isMixedInBy_ClassDeclaration() {
     _indexTestUnit('''
 class A {} // 1
 class B extends Object with A {} // 2
 ''');
     ClassElement elementA = findElement('A');
     assertThat(elementA)
       ..isMixedInAt('A {} // 2', false)
       ..isReferencedAt('A {} // 2', false);
   }
@@ skipping 213 matching lines @@
   A.bar();
 }
 ''');
     ClassElement classA = findElement('A');
     ConstructorElement constA = classA.constructors[0];
     ConstructorElement constA_bar = classA.constructors[2];
     assertThat(constA).isReferencedAt('(); // 2', true, length: 0);
     assertThat(constA_bar).isReferencedAt('.bar(); // 1', true, length: 4);
   }
 
+  void test_isReferencedBy_ConstructorElement_synthetic() {
+    _indexTestUnit('''
+class A {}
+main() {
+  new A(); // 1
+}
+''');
+    ClassElement classA = findElement('A');
+    ConstructorElement constA = classA.constructors[0];
+    // A()
+    assertThat(constA)..isReferencedAt('(); // 1', true, length: 0);
+  }
+
   void test_isReferencedBy_ConstructorFieldInitializer() {
     _indexTestUnit('''
 class A {
   int field;
   A() : field = 5;
 }
 ''');
     FieldElement element = findElement('field');
     assertThat(element).isReferencedAt('field = 5', true);
   }
@@ skipping 239 matching lines @@
     String packageIndexJsonString =
         new JsonEncoder.withIndent('  ').convert(packageIndex.toJson());
     fail('$msg in\n' + packageIndexJsonString);
   }
 
   /**
    * Return the [element] identifier in [packageIndex] or fail.
    */
   int _findElementId(Element element) {
     int unitId = _getUnitId(element);
-    int offset = element.nameOffset;
-    if (element is LibraryElement || element is CompilationUnitElement) {
-      offset = 0;
-    }
-    IndexSyntheticElementKind kind =
-        PackageIndexAssembler.getIndexElementKind(element);
+    ElementInfo info = PackageIndexAssembler.newElementInfo(unitId, element);
     for (int elementId = 0;
         elementId < packageIndex.elementUnits.length;
         elementId++) {
       if (packageIndex.elementUnits[elementId] == unitId &&
-          packageIndex.elementOffsets[elementId] == offset &&
-          packageIndex.elementKinds[elementId] == kind) {
+          packageIndex.elementOffsets[elementId] == info.offset &&
+          packageIndex.elementKinds[elementId] == info.kind) {
         return elementId;
       }
     }
     _failWithIndexDump('Element $element is not referenced');
     return 0;
   }
 
   int _getStringId(String str) {
     int id = packageIndex.strings.indexOf(str);
     expect(id, isNonNegative);
@@ skipping 93 matching lines @@
   void isNotReferencedAt(String search, {int length}) {
     test._assertUsedName(name, IndexRelationKind.IS_REFERENCED_BY,
         test._expectedLocation(search, true, length: length), true);
   }
 
   void isReferencedAt(String search, {int length}) {
     test._assertUsedName(name, IndexRelationKind.IS_REFERENCED_BY,
         test._expectedLocation(search, true, length: length), false);
   }
 }