Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 1779023002: Trying to fix SQLResultSetRowList's subscript operator to do type conversion (Closed)

Created:
4 years, 9 months ago by Alan Knight
Modified:
4 years, 9 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Trying to fix SQLResultSetRowList's subscript operator to do type conversion BUG= Committed: https://github.com/dart-lang/sdk/commit/051451d7e69bd39bc273fce314f77b3e4eb96a2a

Patch Set 1 #

Patch Set 2 : Forgot a file #

Patch Set 3 : Use _OperationRequiresConversion instead of supplemental IDL" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 2 3 chunks +9 lines, -4 lines 0 comments Download
M tools/dom/dom.json View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
Alan Knight
TBR
4 years, 9 months ago (2016-03-09 22:02:24 UTC) #2
Alan Knight
4 years, 9 months ago (2016-03-09 22:02:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
051451d7e69bd39bc273fce314f77b3e4eb96a2a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698