tools/dom/scripts/systemhtml.py - Issue 1779023002: Trying to fix SQLResultSetRowList's subscript operator to do type conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/systemhtml.py

Issue 1779023002: Trying to fix SQLResultSetRowList's subscript operator to do type conversion (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Use _OperationRequiresConversion instead of supplemental IDL" Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/scripts/systemhtml.py

diff --git a/tools/dom/scripts/systemhtml.py b/tools/dom/scripts/systemhtml.py

index b31b23d9bb5fbef285295bd9f14ef7706be6727e..672d97e7a1faaed2eda62a1fd0b2b10ea104d85f 100644

--- a/tools/dom/scripts/systemhtml.py

+++ b/tools/dom/scripts/systemhtml.py

@@ -828,7 +828,8 @@ class Dart2JSBackend(HtmlDartGenerator):

ext_attrs = self._interface.ext_attrs

has_indexed_getter = 'CustomIndexedGetter' in ext_attrs

for operation in self._interface.operations:

- if operation.id == 'item' and 'getter' in operation.specials:

+ if operation.id == 'item' and 'getter' in operation.specials \

+ and not self._OperationRequiresConversions(operation):

has_indexed_getter = True

break

return has_indexed_getter

« no previous file with comments | « tools/dom/scripts/generator.py ('k') | no next file » | no next file with comments »