Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: net/tools/gdig/gdig.cc

Issue 1778933002: DNS: Per-network-type and Finch-variable timeouts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix NaCl build issue? Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/dns/host_resolver_impl.cc ('K') | « net/dns/host_resolver_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/gdig/gdig.cc
diff --git a/net/tools/gdig/gdig.cc b/net/tools/gdig/gdig.cc
index e0af40fbff9920a2d43add5bceeda86d3bf2c085..e0a6fa1c33a94be0b4916052c196aa345b9df5ce 100644
--- a/net/tools/gdig/gdig.cc
+++ b/net/tools/gdig/gdig.cc
@@ -77,7 +77,7 @@ std::string DnsConfigToString(const DnsConfig& dns_config) {
base::StringAppendF(&output, "options ndots:%d\n", dns_config.ndots);
base::StringAppendF(&output, "options timeout:%d\n",
- static_cast<int>(dns_config.timeout.InMilliseconds()));
+ static_cast<int>(dns_config.timeout.InSeconds()));
Randy Smith (Not in Mondays) 2016/03/15 20:12:30 Why?
Deprecated (see juliatuttle) 2016/03/16 16:45:30 This was wrong; see the man page for resolv.conf.
Randy Smith (Not in Mondays) 2016/03/16 20:11:07 Separate CL or mention in CL description?
base::StringAppendF(&output, "options attempts:%d\n", dns_config.attempts);
if (dns_config.rotate)
output.append("options rotate\n");
« net/dns/host_resolver_impl.cc ('K') | « net/dns/host_resolver_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698