DNS: Per-network-type and Finch-variable timeouts

net/tools/gdig/gdig.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdio.h>
 #include <string>
 #include <utility>
 
 #include "base/at_exit.h"
 #include "base/bind.h"
@@ skipping 59 matching lines @@
   }
   output.append("\n");
 
   for (size_t i = 0; i < dns_config.nameservers.size(); ++i) {
     output.append("nameserver ");
     output.append(dns_config.nameservers[i].ToString()).append("\n");
   }
 
   base::StringAppendF(&output, "options ndots:%d\n", dns_config.ndots);
   base::StringAppendF(&output, "options timeout:%d\n",
-                      static_cast<int>(dns_config.timeout.InMilliseconds()));
+                      static_cast<int>(dns_config.timeout.InSeconds()));

[Randy Smith (Not in Mondays), 2016/03/15 20:12:30]

Why?

[Deprecated (see juliatuttle), 2016/03/16 16:45:30]

This was wrong; see the man page for resolv.conf. timeout is in seconds, not
milliseconds.

[Randy Smith (Not in Mondays), 2016/03/16 20:11:07]

Separate CL or mention in CL description?

   base::StringAppendF(&output, "options attempts:%d\n", dns_config.attempts);
   if (dns_config.rotate)
     output.append("options rotate\n");
   if (dns_config.edns0)
     output.append("options edns0\n");
   return output;
 }
 
 // Convert DnsConfig hosts member to a human readable text.
 std::string DnsHostsToString(const DnsHosts& dns_hosts) {
@@ skipping 421 matching lines @@
 }
 
 }  // empty namespace
 
 }  // namespace net
 
 int main(int argc, const char* argv[]) {
   net::GDig dig;
   return dig.Main(argc, argv);
 }