chrome/browser/lifetime/keep_alive_registry.h - Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/keep_alive_registry.h

Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KAObserver

Patch Set: replace the commented dcheck by a dlog Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/lifetime/browser_close_manager_browsertest.cc ('k') | chrome/browser/lifetime/keep_alive_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/lifetime/keep_alive_registry.h

diff --git a/chrome/browser/lifetime/keep_alive_registry.h b/chrome/browser/lifetime/keep_alive_registry.h

index f504fa072c790cd0eec13f6efdf8a9991812c3be..cd0d4128b71adb002eaae3d026523131524b328e 100644

--- a/chrome/browser/lifetime/keep_alive_registry.h

+++ b/chrome/browser/lifetime/keep_alive_registry.h

@@ -21,8 +21,8 @@ class KeepAliveRegistry {

// Methods to query the state of the registry.

// TODO(dgn): This currently does not give a complete picture. It has no

- // information about the many places that rely on IncrementKeepAliveCount and

- // AddRefModule to keep the browser alive. Tracked by https://crbug.com/587926

+ // information about the many places that rely on AddRefModule to keep the

+ // browser alive. Tracked by https://crbug.com/587926

bool IsKeepingAlive() const;

bool IsRestartAllowed() const;

« no previous file with comments | « chrome/browser/lifetime/browser_close_manager_browsertest.cc ('k') | chrome/browser/lifetime/keep_alive_registry.cc » ('j') | no next file with comments »