Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Side by Side Diff: chrome/browser/lifetime/keep_alive_registry.h

Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KAObserver
Patch Set: replace the commented dcheck by a dlog Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_LIFETIME_KEEP_ALIVE_REGISTRY_H_ 5 #ifndef CHROME_BROWSER_LIFETIME_KEEP_ALIVE_REGISTRY_H_
6 #define CHROME_BROWSER_LIFETIME_KEEP_ALIVE_REGISTRY_H_ 6 #define CHROME_BROWSER_LIFETIME_KEEP_ALIVE_REGISTRY_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/memory/singleton.h" 11 #include "base/memory/singleton.h"
12 #include "base/observer_list.h" 12 #include "base/observer_list.h"
13 13
14 enum class KeepAliveOrigin; 14 enum class KeepAliveOrigin;
15 enum class KeepAliveRestartOption; 15 enum class KeepAliveRestartOption;
16 class KeepAliveStateObserver; 16 class KeepAliveStateObserver;
17 17
18 class KeepAliveRegistry { 18 class KeepAliveRegistry {
19 public: 19 public:
20 static KeepAliveRegistry* GetInstance(); 20 static KeepAliveRegistry* GetInstance();
21 21
22 // Methods to query the state of the registry. 22 // Methods to query the state of the registry.
23 // TODO(dgn): This currently does not give a complete picture. It has no 23 // TODO(dgn): This currently does not give a complete picture. It has no
24 // information about the many places that rely on IncrementKeepAliveCount and 24 // information about the many places that rely on AddRefModule to keep the
25 // AddRefModule to keep the browser alive. Tracked by https://crbug.com/587926 25 // browser alive. Tracked by https://crbug.com/587926
26 bool IsKeepingAlive() const; 26 bool IsKeepingAlive() const;
27 bool IsRestartAllowed() const; 27 bool IsRestartAllowed() const;
28 28
29 void AddObserver(KeepAliveStateObserver* observer); 29 void AddObserver(KeepAliveStateObserver* observer);
30 void RemoveObserver(KeepAliveStateObserver* observer); 30 void RemoveObserver(KeepAliveStateObserver* observer);
31 31
32 private: 32 private:
33 friend struct base::DefaultSingletonTraits<KeepAliveRegistry>; 33 friend struct base::DefaultSingletonTraits<KeepAliveRegistry>;
34 // Friend to be able to use Register/Unregister 34 // Friend to be able to use Register/Unregister
35 friend class ScopedKeepAlive; 35 friend class ScopedKeepAlive;
(...skipping 24 matching lines...) Expand all
60 base::ObserverList<KeepAliveStateObserver> observers_; 60 base::ObserverList<KeepAliveStateObserver> observers_;
61 61
62 DISALLOW_COPY_AND_ASSIGN(KeepAliveRegistry); 62 DISALLOW_COPY_AND_ASSIGN(KeepAliveRegistry);
63 }; 63 };
64 64
65 #ifndef NDEBUG 65 #ifndef NDEBUG
66 std::ostream& operator<<(std::ostream& out, const KeepAliveRegistry& registry); 66 std::ostream& operator<<(std::ostream& out, const KeepAliveRegistry& registry);
67 #endif // ndef NDEBUG 67 #endif // ndef NDEBUG
68 68
69 #endif // CHROME_BROWSER_LIFETIME_KEEP_ALIVE_REGISTRY_H_ 69 #endif // CHROME_BROWSER_LIFETIME_KEEP_ALIVE_REGISTRY_H_
OLDNEW
« no previous file with comments | « chrome/browser/lifetime/browser_close_manager_browsertest.cc ('k') | chrome/browser/lifetime/keep_alive_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698