Chromium Code Reviews Chromium Code Reviews
Issue 1778853002:
[css-grid] Fix height computation for items with intrinsic aspect ratios (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..9ab944b404d182f5638ff5d86104621fa694e36d |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html |
| @@ -0,0 +1,48 @@ |
| +<!DOCTYPE html> |
| + |
| +<style> |
| + |
| +.container { |
| + border: 5px solid orange; |
| + width: min-content; |
| + display: grid; |
| +} |
| + |
| +</style> |
| + |
| +<p>This test shows how min-width:auto is computed for items with intrinisc aspect ratios</p> |
|
Manuel Rego
2016/03/14 14:38:09
Only min-width or both?
The patch title talks abo
svillar
2016/03/17 13:33:54
Correct, both.
|
| + |
| +<p>Check that width respects the intrinsic aspect ratio when specifying the height</p> |
|
Manuel Rego
2016/03/14 14:38:09
You're not testing here combinations like:
min-h
svillar
2016/03/17 13:33:54
Acknowledged.
|
| +<div class="container"> |
| + <img src="resources/100x50.png" style="height: 25px;"/> |
|
Manuel Rego
2016/03/14 14:38:09
Nit: Maybe we can rename the picture and call it "
svillar
2016/03/17 13:33:54
Acknowledged.
|
| +</div> |
| + |
| +<div class="container"> |
| + <img src="resources/100x50.png" style="height: 25px; min-height: 30px;"/> |
| +</div> |
| + |
| +<div class="container"> |
| + <img src="resources/100x50.png" style="height: 25px; max-width: 40px;"/> |
| +</div> |
| + |
| +<div class="container"> |
| + <img src="resources/100x50.png" style="height: 25px; min-height: 30px; max-width: 50px;"/> |
| +</div> |
| + |
| + |
| +<p>Check that height respects the intrinsic aspect ratio when specifying the width</p> |
|
Manuel Rego
2016/03/14 14:38:09
You're not testing here combinations like:
width
svillar
2016/03/17 13:33:54
Acknowledged.
|
| +<div class="container"> |
| + <img src="resources/100x50.png" style="width: 50px;"/> |
| +</div> |
| + |
| +<div class="container"> |
| + <img src="resources/100x50.png" style="max-width: 60px;"/> |
| +</div> |
| + |
| +<div class="container"> |
| + <img src="resources/100x50.png" style="min-width: 120px;"/> |
| +</div> |
| + |
| +<div class="container"> |
| + <img src="resources/100x50.png" style="width: 60px; min-width: 80px;"/> |
| +</div> |
