third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html - Issue 1778853002: [css-grid] Fix height computation for items with intrinsic aspect ratios

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html

Issue 1778853002: [css-grid] Fix height computation for items with intrinsic aspect ratios (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio-expected.html » ('j') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <style>

	4

	5 .container {

	6 border: 5px solid orange;

	7 width: min-content;

	8 display: grid;

	9 }

	10

	11 </style>

	12

	13 <p>This test shows how min-width:auto is computed for items with intrinisc aspec t ratios</p>
	Manuel Rego 2016/03/14 14:38:09 Only min-width or both? The patch title talks abo Only min-width or both? The patch title talks about height. svillar 2016/03/17 13:33:54 Correct, both. Show quoted text On 2016/03/14 14:38:09, Manuel Rego wrote: > Only min-width or both? > > The patch title talks about height. Correct, both.
	14

	15 <p>Check that width respects the intrinsic aspect ratio when specifying the heig ht</p>
	Manuel Rego 2016/03/14 14:38:09 You're not testing here combinations like: min-h You're not testing here combinations like: min-height: 200px; max-height: 50px; Like you're doing in the 2nd part of the test. svillar 2016/03/17 13:33:54 Acknowledged. Show quoted text On 2016/03/14 14:38:09, Manuel Rego wrote: > You're not testing here combinations like: > min-height: 200px; > max-height: 50px; > > Like you're doing in the 2nd part of the test. Acknowledged.
	16 <div class="container">

	17 <img src="resources/100x50.png" style="height: 25px;"/>
	Manuel Rego 2016/03/14 14:38:09 Nit: Maybe we can rename the picture and call it " Nit: Maybe we can rename the picture and call it "blue-100x50.png". svillar 2016/03/17 13:33:54 Acknowledged. Show quoted text On 2016/03/14 14:38:09, Manuel Rego wrote: > Nit: Maybe we can rename the picture and call it "blue-100x50.png". Acknowledged.
	18 </div>

	19

	20 <div class="container">

	21 <img src="resources/100x50.png" style="height: 25px; min-height: 30px;"/>

	22 </div>

	23

	24 <div class="container">

	25 <img src="resources/100x50.png" style="height: 25px; max-width: 40px;"/>

	26 </div>

	27

	28 <div class="container">

	29 <img src="resources/100x50.png" style="height: 25px; min-height: 30px; max-w idth: 50px;"/>

	30 </div>

	31

	32

	33 <p>Check that height respects the intrinsic aspect ratio when specifying the wid th</p>
	Manuel Rego 2016/03/14 14:38:09 You're not testing here combinations like: width You're not testing here combinations like: width: 25px; max-width: 40px; width: 100px; max-height: 25px; width: 25px; min-height: 100px; Like you're doing in the first part. svillar 2016/03/17 13:33:54 Acknowledged. Show quoted text On 2016/03/14 14:38:09, Manuel Rego wrote: > You're not testing here combinations like: > width: 25px; max-width: 40px; > width: 100px; max-height: 25px; > width: 25px; min-height: 100px; > > Like you're doing in the first part. Acknowledged.
	34 <div class="container">

	35 <img src="resources/100x50.png" style="width: 50px;"/>

	36 </div>

	37

	38 <div class="container">

	39 <img src="resources/100x50.png" style="max-width: 60px;"/>

	40 </div>

	41

	42 <div class="container">

	43 <img src="resources/100x50.png" style="min-width: 120px;"/>

	44 </div>

	45

	46 <div class="container">

	47 <img src="resources/100x50.png" style="width: 60px; min-width: 80px;"/>

	48 </div>

OLD	NEW