Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp

Issue 1778773002: [bindings] remove @@iterator from Window (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove expected failure Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp
diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp b/third_party/WebKit/Source/bindings/templates/interface_base.cpp
index c242de81831bb596d08a86cca719f4f9883c814f..ab9a0ec51afbe8e751104bc6a91bd21f84c5f170 100644
--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp
+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp
@@ -336,9 +336,7 @@ static void install{{v8_class}}Template(v8::Local<v8::FunctionTemplate> interfac
{%- if has_array_iterator %}{{newline}}
// Array iterator
{% filter runtime_enabled('RuntimeEnabledFeatures::iterableCollectionsEnabled') %}
- {% if is_global %}
- instanceTemplate->SetIntrinsicDataProperty(v8::Symbol::GetIterator(isolate), v8::kArrayProto_values, v8::DontEnum);
- {% else %}
+ {% if not is_global %}
Yuki 2016/03/09 04:19:30 It's better to merge this condition into line 336.
caitp (gmail) 2016/03/09 04:34:02 in fact, per spec it should be false, the indexed
prototypeTemplate->SetIntrinsicDataProperty(v8::Symbol::GetIterator(isolate), v8::kArrayProto_values, v8::DontEnum);
{% endif %}
{% endfilter %}

Powered by Google App Engine
This is Rietveld 408576698