[bindings] remove @@iterator from Window

third_party/WebKit/Source/bindings/templates/interface_base.cpp

 {% include 'copyright_block.txt' %}
 #include "{{v8_class_or_partial}}.h"
 
 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}
 #include "{{filename}}"
 {% endfor %}
 
 namespace blink {
 {% set visit_dom_wrapper = '%s::visitDOMWrapper' % v8_class
                            if has_visit_dom_wrapper else '0' %}
@@ skipping 318 matching lines @@
     {% endif %}
 
     {%- if has_access_check_callbacks %}{{newline}}
     // Cross-origin access check
     instanceTemplate->SetAccessCheckCallback({{cpp_class}}V8Internal::securityCheck, v8::External::New(isolate, const_cast<WrapperTypeInfo*>(&{{v8_class}}::wrapperTypeInfo)));
     {% endif %}
 
     {%- if has_array_iterator %}{{newline}}
     // Array iterator
     {% filter runtime_enabled('RuntimeEnabledFeatures::iterableCollectionsEnabled') %}
-    {% if is_global %}
-    instanceTemplate->SetIntrinsicDataProperty(v8::Symbol::GetIterator(isolate), v8::kArrayProto_values, v8::DontEnum);
-    {% else %}
+    {% if not is_global %}

[Yuki, 2016/03/09 04:19:30]

It's better to merge this condition into line 336.

{%- if has_array_iterator and not is_global %}

Or edit v8_interface.py so that has_array_iterator will be false for [Global]
interfaces.

[caitp (gmail), 2016/03/09 04:34:02]

in fact, per spec it should be false, the indexed property getter is supposed to
be moved to WindowProxy. the conditional is a short term workaround for that.
anyways, ill put them on one line.

     prototypeTemplate->SetIntrinsicDataProperty(v8::Symbol::GetIterator(isolate), v8::kArrayProto_values, v8::DontEnum);
     {% endif %}
     {% endfilter %}
     {% endif %}
 
     {%- set runtime_enabled_features = dict() %}
     {% for attribute in attributes
        if attribute.runtime_enabled_function and
           not attribute.exposed_test %}
         {% if attribute.runtime_enabled_function not in runtime_enabled_features %}
@@ skipping 86 matching lines @@
 {{method_implemented_in_private_script(method)}}
 {% endfor %}
 {% for attribute in attributes if attribute.is_implemented_in_private_script %}
 {{attribute_getter_implemented_in_private_script(attribute)}}
 {% if attribute.has_setter %}
 {{attribute_setter_implemented_in_private_script(attribute)}}
 {% endif %}
 {% endfor %}
 {% block partial_interface %}{% endblock %}
 } // namespace blink