[bindings] remove @@iterator from Window

[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead (https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821)

BUG=593174, 538558
LOG=N
R=yukishiino@chromium.org, haraken@chromium.org

Committed: https://crrev.com/02a0abbbdb24780320afc40d02c3114b1045b8e0
Cr-Commit-Position: refs/heads/master@{#381464}

[caitp (gmail), 2016-03-09 01:23:59]

PTAL --- Domenic if you could provide more context for this spec change, I'd
like to add it to the CL description, thanks. I'm told you had something to do
with the change.

[caitp (gmail), 2016-03-09 01:26:04]

Description was changed from

==========
[bindings] remove @@iterator from Window

According to Boris Zbarsky, Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification.

BUG=593174
LOG=N
R=domenic@chromium.org, tkent@chromium.org, haraken@chromium.org
==========

to

==========
[bindings] remove @@iterator from Window

According to Boris Zbarsky, Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification.

BUG=593174, 538558
LOG=N
R=domenic@chromium.org, tkent@chromium.org, haraken@chromium.org
==========

[caitp (gmail), 2016-03-09 01:46:09]

Description was changed from

==========
[bindings] remove @@iterator from Window

According to Boris Zbarsky, Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification.

BUG=593174, 538558
LOG=N
R=domenic@chromium.org, tkent@chromium.org, haraken@chromium.org
==========

to

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the indexed
getter being removed, and handled in WindowProxy instead.

BUG=593174, 538558
LOG=N
R=domenic@chromium.org, tkent@chromium.org, haraken@chromium.org
==========

[caitp (gmail), 2016-03-09 01:46:20]

Description was changed from

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the indexed
getter being removed, and handled in WindowProxy instead.

BUG=593174, 538558
LOG=N
R=domenic@chromium.org, tkent@chromium.org, haraken@chromium.org
==========

to

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead.

BUG=593174, 538558
LOG=N
R=domenic@chromium.org, tkent@chromium.org, haraken@chromium.org
==========

[caitp (gmail), 2016-03-09 01:49:27]

Description was changed from

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead.

BUG=593174, 538558
LOG=N
R=domenic@chromium.org, tkent@chromium.org, haraken@chromium.org
==========

to

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead
(https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821)

BUG=593174, 538558
LOG=N
R=domenic@chromium.org, tkent@chromium.org, haraken@chromium.org
==========

[Yuki, 2016-03-09 04:19:29]

yukishiino@chromium.org changed reviewers:
+ yukishiino@chromium.org

[Yuki, 2016-03-09 04:19:30]

https://codereview.chromium.org/1778773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/templates/interface_base.cpp (right):

https://codereview.chromium.org/1778773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/interface_base.cpp:339: {% if not
is_global %}
It's better to merge this condition into line 336.

{%- if has_array_iterator and not is_global %}

Or edit v8_interface.py so that has_array_iterator will be false for [Global]
interfaces.

[caitp (gmail), 2016-03-09 04:34:02]

thx, one moment

https://codereview.chromium.org/1778773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/templates/interface_base.cpp (right):

https://codereview.chromium.org/1778773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/interface_base.cpp:339: {% if not
is_global %}
On 2016/03/09 04:19:30, Yuki wrote:
> It's better to merge this condition into line 336.
> 
> {%- if has_array_iterator and not is_global %}
> 
> Or edit v8_interface.py so that has_array_iterator will be false for [Global]
> interfaces.

in fact, per spec it should be false, the indexed property getter is supposed to
be moved to WindowProxy. the conditional is a short term workaround for that.
anyways, ill put them on one line.

[caitp (gmail), 2016-03-09 04:55:15]

Description was changed from

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead
(https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821)

BUG=593174, 538558
LOG=N
R=domenic@chromium.org, tkent@chromium.org, haraken@chromium.org
==========

to

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead
(https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821)

BUG=593174, 538558
LOG=N
R=domenic@chromium.org, tkent@chromium.org, haraken@chromium.org,
yukishiino@chromium.org
==========

[domenic, 2016-03-09 17:11:17]

On 2016/03/09 at 01:23:59, caitpotter88 wrote:
> PTAL --- Domenic if you could provide more context for this spec change, I'd
like to add it to the CL description, thanks. I'm told you had something to do
with the change.

So, this apparently occurred as an accidental side-effect of
https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821,
which moved the indexed getter behavior to WindowProxy
(https://html.spec.whatwg.org/#windowproxy-getownproperty). Since it is now
defined there, instead of on Window where `length` is defined, IDL's automatic
"length + indexed getter = add an @@iterator" no longer applies.

I've opened a bit of discussion about this in
https://github.com/w3c/web-platform-tests/pull/2649#issuecomment-194057682 since
it seems strange to me that we regressed the spec on this and everyone wants to
move forward with the change. But I guess Boris prefers this, so maybe things
will stay that way?

[caitp (gmail), 2016-03-10 17:53:34]

On 2016/03/09 17:11:17, domenic wrote:
> On 2016/03/09 at 01:23:59, caitpotter88 wrote:
> > PTAL --- Domenic if you could provide more context for this spec change, I'd
> like to add it to the CL description, thanks. I'm told you had something to do
> with the change.
> 
> So, this apparently occurred as an accidental side-effect of
>
https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821,
> which moved the indexed getter behavior to WindowProxy
> (https://html.spec.whatwg.org/#windowproxy-getownproperty). Since it is now
> defined there, instead of on Window where `length` is defined, IDL's automatic
> "length + indexed getter = add an @@iterator" no longer applies.
> 
> I've opened a bit of discussion about this in
> https://github.com/w3c/web-platform-tests/pull/2649#issuecomment-194057682
since
> it seems strange to me that we regressed the spec on this and everyone wants
to
> move forward with the change. But I guess Boris prefers this, so maybe things
> will stay that way?

Realistically, I don't think there was a very strong use-case for iterating
through the list of frames --- I saw a single StackOverflow post asking for a
way to do this, and not having @@iterator on Window doesn't really make it
impossible.

I think it's okay to get rid of @@iterator on Window, unless anyone can think of
a strong reason not to. So long as it's still available for the more
OrderedSet-style interfaces, it probably won't upset anybody.

[caitp (gmail), 2016-03-16 14:21:16]

Ping

[Yuki, 2016-03-16 14:30:59]

LGTM.

[caitp (gmail), 2016-03-16 14:32:18]

Description was changed from

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead
(https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821)

BUG=593174, 538558
LOG=N
R=domenic@chromium.org, tkent@chromium.org, haraken@chromium.org,
yukishiino@chromium.org
==========

to

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead
(https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821)

BUG=593174, 538558
LOG=N
R=yukishiino@chromium.org
==========

[caitp (gmail), 2016-03-16 14:32:26]

The CQ bit was checked by caitpotter88@gmail.com

[commit-bot: I haz the power, 2016-03-16 14:32:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778773002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778773002/60001

[haraken, 2016-03-16 14:35:39]

LGTM

[caitp (gmail), 2016-03-16 14:38:51]

Description was changed from

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead
(https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821)

BUG=593174, 538558
LOG=N
R=yukishiino@chromium.org
==========

to

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead
(https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821)

BUG=593174, 538558
LOG=N
R=yukishiino@chromium.org, haraken@chromium.org
==========

[commit-bot: I haz the power, 2016-03-16 16:14:13]

Description was changed from

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead
(https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821)

BUG=593174, 538558
LOG=N
R=yukishiino@chromium.org, haraken@chromium.org
==========

to

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead
(https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821)

BUG=593174, 538558
LOG=N
R=yukishiino@chromium.org, haraken@chromium.org
==========

[commit-bot: I haz the power, 2016-03-16 16:14:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-16 16:16:59]

Description was changed from

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead
(https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821)

BUG=593174, 538558
LOG=N
R=yukishiino@chromium.org, haraken@chromium.org
==========

to

==========
[bindings] remove @@iterator from Window

Window is now exempt from the WebIDL policy granting
@@iterator to Array-like objects, as of a recent change to the Window
specification (https://html.spec.whatwg.org/#window) --- due to the
indexed getter being removed, and handled in WindowProxy instead
(https://github.com/whatwg/html/commit/acae3df652b382e9f4f1d1b4dc7e08e2b00df821)

BUG=593174, 538558
LOG=N
R=yukishiino@chromium.org, haraken@chromium.org

Committed: https://crrev.com/02a0abbbdb24780320afc40d02c3114b1045b8e0
Cr-Commit-Position: refs/heads/master@{#381464}
==========

[commit-bot: I haz the power, 2016-03-16 16:17:00]

Patchset 4 (id:??) landed as
https://crrev.com/02a0abbbdb24780320afc40d02c3114b1045b8e0
Cr-Commit-Position: refs/heads/master@{#381464}