Make <custom-ident> not insert quotes

Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that by calling serializeIdentifier.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior, but with the change that previously we used
single quotes, now double quotes [3]. Most of the expected test
changes are because of this.

In order to fix parsing-css-string-characters.html and
string-quote-binary.html completely, the U+007F handling
mentioned in [3] is implemented.

Behavior matches Firefox.

BUG=584999
[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
[3] https://drafts.csswg.org/cssom/#serialize-a-string

Committed: https://crrev.com/0c2c3981d4621fc6f5525e01f4de2a14cbc2d15e
Cr-Commit-Position: refs/heads/master@{#381619}

[rwlbuis, 2016-03-11 21:43:06]

Patchset #7 (id:120001) has been deleted

[rwlbuis, 2016-03-14 20:18:16]

Patchset #10 (id:200001) has been deleted

[rwlbuis, 2016-03-14 21:25:17]

Description was changed from

==========
584999 WIP

BUG=
==========

to

==========
584999 WIP

BUG=584999
==========

[rwlbuis, 2016-03-14 21:36:58]

Description was changed from

==========
584999 WIP

BUG=584999
==========

to

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
insert quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that my reusing DOMWindowCSS::escape.
Since the font family relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
==========

[rwlbuis, 2016-03-14 21:37:13]

Description was changed from

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
insert quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that my reusing DOMWindowCSS::escape.
Since the font family relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
==========

to

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that my reusing DOMWindowCSS::escape.
Since the font family relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
==========

[rwlbuis, 2016-03-14 21:38:14]

Description was changed from

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that my reusing DOMWindowCSS::escape.
Since the font family relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
==========

to

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that my reusing DOMWindowCSS::escape.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
==========

[rwlbuis, 2016-03-14 21:41:41]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2016-03-14 21:41:42]

PTAL.

Note that Firefox actually has a slight difference in these two tests:
fast/css/parsing-css-string-characters.html
fast/css/string-quote-binary.html

I am not sure which one is correct? This only shows up now I guess because
we end up serializing with the new serializeString instead of the old
quoteCSSStringIfNeeded.

[Timothy Loh, 2016-03-14 23:25:11]

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/editing/pasteboard/data-transfer-items.html
(right):

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/editing/pasteboard/data-transfer-items.html:25:
return text.replace(/font-family: .+;; /, '');
I don't get this, what does the text argument look like here?

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp (right):

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp:31: return
DOMWindowCSS::escape(m_string);
IMO we should call the underlying conversion function and not use DOMWindowCSS.
DOMWindowCSS only really exists to expose functions to the web.

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/CSSMarkup.h (right):

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/CSSMarkup.h:37: String
serializeStringIfNeeded(const String&);
serializeFontFamily?

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/CSSValuePool.h (right):

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/CSSValuePool.h:34: #include
"core/css/CSSFontFamilyValue.h"
can this be a forwards declaration? otherwise you're including it in both the h
and cpp files

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/editing/EditingStyle.cpp (right):

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/EditingStyle.cpp:1561: // Remove single
quotes for Outlook 2007 compatibility. See
https://bugs.webkit.org/show_bug.cgi?id=79448
single -> double?

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/EditingStyle.cpp:1562:
m_applyFontFace.replaceWithLiteral('\"', "");
no need for backslash

[rwlbuis, 2016-03-15 18:29:44]

On 2016/03/14 21:41:42, rwlbuis wrote:
> PTAL.
> 
> Note that Firefox actually has a slight difference in these two tests:
> fast/css/parsing-css-string-characters.html
> fast/css/string-quote-binary.html
> 
> I am not sure which one is correct? This only shows up now I guess because
> we end up serializing with the new serializeString instead of the old
> quoteCSSStringIfNeeded.

Actually I tracked above problem down to us not supporting the 7F case:
(https://drafts.csswg.org/cssom/#escape-a-character)
"If the character is in the range [\1-\1f] (U+0001 to U+001F) or is U+007F, the
character escaped as code point."

This is fixed in patch set #12 and also updated the test results for above two
tests. Let me know if this should be part of this patch though (if it can stay
in this patch I'll update the Description).

[rwlbuis, 2016-03-15 18:30:14]

Description was changed from

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that my reusing DOMWindowCSS::escape.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
==========

to

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that by calling serializeIdentifier.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
==========

[rwlbuis, 2016-03-15 18:34:15]

PTAL.

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/editing/pasteboard/data-transfer-items.html
(right):

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/editing/pasteboard/data-transfer-items.html:25:
return text.replace(/font-family: .+;; /, '');
On 2016/03/14 23:25:11, Timothy Loh wrote:
> I don't get this, what does the text argument look like here?

You are right, this is tricky. core/editing/serializers/MarkupFormatter.cpp
causes '"' to be replaced by ", previously "'" was not replaced. I had to
change the regexp in a few other tests as well.

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp (right):

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp:31: return
DOMWindowCSS::escape(m_string);
On 2016/03/14 23:25:11, Timothy Loh wrote:
> IMO we should call the underlying conversion function and not use
DOMWindowCSS.
> DOMWindowCSS only really exists to expose functions to the web.

Done.

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/CSSMarkup.h (right):

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/CSSMarkup.h:37: String
serializeStringIfNeeded(const String&);
On 2016/03/14 23:25:11, Timothy Loh wrote:
> serializeFontFamily?

Done.

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/CSSValuePool.h (right):

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/CSSValuePool.h:34: #include
"core/css/CSSFontFamilyValue.h"
On 2016/03/14 23:25:11, Timothy Loh wrote:
> can this be a forwards declaration? otherwise you're including it in both the
h
> and cpp files

Not possible unfortunately, but I removed the include in the .cpp.

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/editing/EditingStyle.cpp (right):

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/EditingStyle.cpp:1561: // Remove single
quotes for Outlook 2007 compatibility. See
https://bugs.webkit.org/show_bug.cgi?id=79448
On 2016/03/14 23:25:11, Timothy Loh wrote:
> single -> double?

Done.

https://codereview.chromium.org/1778743003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/EditingStyle.cpp:1562:
m_applyFontFace.replaceWithLiteral('\"', "");
On 2016/03/14 23:25:11, Timothy Loh wrote:
> no need for backslash

Done.

[Timothy Loh, 2016-03-15 23:26:45]

On 2016/03/15 18:29:44, rwlbuis wrote:
> On 2016/03/14 21:41:42, rwlbuis wrote:
> > PTAL.
> > 
> > Note that Firefox actually has a slight difference in these two tests:
> > fast/css/parsing-css-string-characters.html
> > fast/css/string-quote-binary.html
> > 
> > I am not sure which one is correct? This only shows up now I guess because
> > we end up serializing with the new serializeString instead of the old
> > quoteCSSStringIfNeeded.
> 
> Actually I tracked above problem down to us not supporting the 7F case:
> (https://drafts.csswg.org/cssom/#escape-a-character)
> "If the character is in the range [\1-\1f] (U+0001 to U+001F) or is U+007F,
the
> character escaped as code point."
> 
> This is fixed in patch set #12 and also updated the test results for above two
> tests. Let me know if this should be part of this patch though (if it can stay
> in this patch I'll update the Description).

I guess it's fine, just mention it :)

lgtm

[rwlbuis, 2016-03-15 23:41:20]

Description was changed from

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that by calling serializeIdentifier.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
==========

to

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that by calling serializeIdentifier.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior.

In order to fix parsing-css-string-characters.html and
string-quote-binary.html completely, the U+007F handling
mentioned in [3] is implemented.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
[3] https://drafts.csswg.org/cssom/#serialize-a-string
==========

[rwlbuis, 2016-03-15 23:42:12]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-03-15 23:42:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778743003/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778743003/260001

[commit-bot: I haz the power, 2016-03-16 00:40:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 00:40:59]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rwlbuis, 2016-03-16 00:51:33]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-03-16 00:51:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778743003/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778743003/260001

[commit-bot: I haz the power, 2016-03-16 01:01:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 01:01:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rwlbuis, 2016-03-16 01:32:03]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-03-16 01:32:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778743003/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778743003/260001

[commit-bot: I haz the power, 2016-03-16 01:43:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 01:43:06]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rwlbuis, 2016-03-16 01:52:34]

On 2016/03/16 01:43:06, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

D'oh! Will fix the browsertest tomorrow.

[Timothy Loh, 2016-03-16 12:37:46]

On 2016/03/16 01:52:34, rwlbuis wrote:
> On 2016/03/16 01:43:06, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> D'oh! Will fix the browsertest tomorrow.

btw the description should probably mention the single -> double quotes change
for font-family

[rwlbuis, 2016-03-16 12:48:02]

On 2016/03/16 12:37:46, Timothy Loh wrote:
> On 2016/03/16 01:52:34, rwlbuis wrote:
> > On 2016/03/16 01:43:06, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> > 
> > D'oh! Will fix the browsertest tomorrow.
> 
> btw the description should probably mention the single -> double quotes change
> for font-family

Will do.

[rwlbuis, 2016-03-16 15:00:43]

Description was changed from

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that by calling serializeIdentifier.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior.

In order to fix parsing-css-string-characters.html and
string-quote-binary.html completely, the U+007F handling
mentioned in [3] is implemented.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
[3] https://drafts.csswg.org/cssom/#serialize-a-string
==========

to

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that by calling serializeIdentifier.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior, but with the change that previously we used
single quotes, now double quotes [3]. Most of the expected test changes
are due to this.

In order to fix parsing-css-string-characters.html and
string-quote-binary.html completely, the U+007F handling
mentioned in [3] is implemented.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
[3] https://drafts.csswg.org/cssom/#serialize-a-string
==========

[rwlbuis, 2016-03-16 15:05:26]

Description was changed from

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that by calling serializeIdentifier.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior, but with the change that previously we used
single quotes, now double quotes [3]. Most of the expected test changes
are due to this.

In order to fix parsing-css-string-characters.html and
string-quote-binary.html completely, the U+007F handling
mentioned in [3] is implemented.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
[3] https://drafts.csswg.org/cssom/#serialize-a-string
==========

to

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that by calling serializeIdentifier.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior, but with the change that previously we used
single quotes, now double quotes [3]. Most of the expected test
changes are because of this.

In order to fix parsing-css-string-characters.html and
string-quote-binary.html completely, the U+007F handling
mentioned in [3] is implemented.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
[3] https://drafts.csswg.org/cssom/#serialize-a-string
==========

[rwlbuis, 2016-03-16 17:17:17]

Patchset #14 (id:300001) has been deleted

[rwlbuis, 2016-03-16 17:18:26]

Patchset #14 (id:320001) has been deleted

[rwlbuis, 2016-03-16 18:18:02]

Patchset #14 (id:340001) has been deleted

[rwlbuis, 2016-03-16 20:05:08]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-03-16 20:05:08]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1778743003/#ps360001
(title: "Fix regexps")

[commit-bot: I haz the power, 2016-03-16 20:05:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778743003/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778743003/360001

[rwlbuis, 2016-03-16 21:29:03]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-03-16 21:29:04]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1778743003/#ps380001
(title: "Fix win_chromium_rel_ng")

[commit-bot: I haz the power, 2016-03-16 21:29:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778743003/380001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778743003/380001

[commit-bot: I haz the power, 2016-03-17 01:08:01]

Description was changed from

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that by calling serializeIdentifier.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior, but with the change that previously we used
single quotes, now double quotes [3]. Most of the expected test
changes are because of this.

In order to fix parsing-css-string-characters.html and
string-quote-binary.html completely, the U+007F handling
mentioned in [3] is implemented.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
[3] https://drafts.csswg.org/cssom/#serialize-a-string
==========

to

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that by calling serializeIdentifier.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior, but with the change that previously we used
single quotes, now double quotes [3]. Most of the expected test
changes are because of this.

In order to fix parsing-css-string-characters.html and
string-quote-binary.html completely, the U+007F handling
mentioned in [3] is implemented.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
[3] https://drafts.csswg.org/cssom/#serialize-a-string
==========

[commit-bot: I haz the power, 2016-03-17 01:08:02]

Committed patchset #15 (id:380001)

[commit-bot: I haz the power, 2016-03-17 01:10:20]

Description was changed from

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that by calling serializeIdentifier.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior, but with the change that previously we used
single quotes, now double quotes [3]. Most of the expected test
changes are because of this.

In order to fix parsing-css-string-characters.html and
string-quote-binary.html completely, the U+007F handling
mentioned in [3] is implemented.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
[3] https://drafts.csswg.org/cssom/#serialize-a-string
==========

to

==========
Make <custom-ident> not insert quotes

Before this patch, <custom-ident> serializing used
quoteCSSStringIfNeeded to serialize, which can end up
inserting quotes.
However <custom-ident> are identifiers [1] and should
serialize as such, meaning no quotes [2].
This patches fixes that by calling serializeIdentifier.

Since the font family property relied on old CSSCustomIdentValue
behavior, this patch adds a CSSFontFamilyValue class to
keep said behavior, but with the change that previously we used
single quotes, now double quotes [3]. Most of the expected test
changes are because of this.

In order to fix parsing-css-string-characters.html and
string-quote-binary.html completely, the U+007F handling
mentioned in [3] is implemented.

Behavior matches Firefox.

BUG=584999

[1] https://drafts.csswg.org/css-values-3/#custom-idents
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier
[3] https://drafts.csswg.org/cssom/#serialize-a-string

Committed: https://crrev.com/0c2c3981d4621fc6f5525e01f4de2a14cbc2d15e
Cr-Commit-Position: refs/heads/master@{#381619}
==========

[commit-bot: I haz the power, 2016-03-17 01:10:23]

Patchset 15 (id:??) landed as
https://crrev.com/0c2c3981d4621fc6f5525e01f4de2a14cbc2d15e
Cr-Commit-Position: refs/heads/master@{#381619}