third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp - Issue 1778743003: Make <custom-ident> not insert quotes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

Issue 1778743003: Make <custom-ident> not insert quotes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix win_chromium_rel_ng Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp b/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

index f8f4e3a1e4f9a1413000857eafe99085b40e687c..e45e1fc08e0fa120a5ab561405085735aa9f8708 100644

--- a/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

@@ -5,6 +5,7 @@

#include "core/css/CSSCustomIdentValue.h"

#include "core/css/CSSMarkup.h"

+#include "wtf/text/StringBuilder.h"

#include "wtf/text/WTFString.h"

namespace blink {

@@ -27,7 +28,9 @@ String CSSCustomIdentValue::customCSSText() const

{

if (isKnownPropertyID())

return getPropertyNameAtomicString(m_propertyId);

- return quoteCSSStringIfNeeded(m_string);

+ StringBuilder builder;

+ serializeIdentifier(m_string, builder);

+ return builder.toString();

}

DEFINE_TRACE_AFTER_DISPATCH(CSSCustomIdentValue)