Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1778693002: Revert of Get rid of gpu related switches by passing gpu::GpuPreferences via IPC. (Closed)

Created:
4 years, 9 months ago by shatch
Modified:
4 years, 9 months ago
Reviewers:
palmer, Peng, boliu, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Get rid of gpu related switches by passing gpu::GpuPreferences via IPC. (patchset #8 id:140001 of https://codereview.chromium.org/1753383003/ ) Reason for revert: Suspecting this is breaking a lot of perf bots. BUG=593045 Original issue's description: > Get rid of gpu related switches by passing gpu::GpuPreferences via IPC. > > BUG=590825 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel > > Committed: https://crrev.com/248b114c9d3034964c7259222712dfcccfad8f48 > Cr-Commit-Position: refs/heads/master@{#379651} TBR=piman@chromium.org,boliu@chromium.org,palmer@chromium.org,penghuang@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=590825 Committed: https://crrev.com/7a1173688cc0e8ff83260231c66fc3e118219c75 Cr-Commit-Position: refs/heads/master@{#379993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -161 lines) Patch
M android_webview/browser/deferred_gpu_command_service.cc View 3 chunks +70 lines, -3 lines 0 comments Download
M content/browser/android/synchronous_compositor_base.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M content/common/gpu/gpu_host_messages.h View 3 chunks +1 line, -30 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 4 chunks +75 lines, -2 lines 0 comments Download
M content/gpu/in_process_gpu_thread.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/gpu/in_process_gpu_thread.cc View 1 chunk +2 lines, -3 lines 0 comments Download
D content/public/browser/gpu_utils.h View 1 chunk +0 lines, -17 lines 0 comments Download
D content/public/browser/gpu_utils.cc View 1 chunk +0 lines, -87 lines 0 comments Download
M gpu/command_buffer/service/gpu_preferences.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_switches.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_switches.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
shatch
Created Revert of Get rid of gpu related switches by passing gpu::GpuPreferences via IPC.
4 years, 9 months ago (2016-03-08 22:48:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778693002/1
4 years, 9 months ago (2016-03-08 22:49:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778693002/1
4 years, 9 months ago (2016-03-08 23:01:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778693002/1
4 years, 9 months ago (2016-03-08 23:32:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778693002/1
4 years, 9 months ago (2016-03-09 00:01:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 00:28:39 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 00:31:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a1173688cc0e8ff83260231c66fc3e118219c75
Cr-Commit-Position: refs/heads/master@{#379993}

Powered by Google App Engine
This is Rietveld 408576698