Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: src/IceTargetLoweringX86Base.h

Issue 1778663003: Subzero: Fix build errors from upgrading to clang 3.9 . (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Makefile.standalone ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringX86Base.h
diff --git a/src/IceTargetLoweringX86Base.h b/src/IceTargetLoweringX86Base.h
index 18a69fde1be6978e9fb2fa7228d265bc7f2c7f5b..01298eb53910b9d006f1a51aadb2077d766b38be 100644
--- a/src/IceTargetLoweringX86Base.h
+++ b/src/IceTargetLoweringX86Base.h
@@ -80,6 +80,9 @@ public:
static void staticInit(GlobalContext *Ctx);
static TargetX86Base *create(Cfg *Func) { return new TargetX86Base(Func); }
John 2016/03/09 16:33:29 instead of adding those three methods, create shou
+ std::unique_ptr<::Ice::Assembler> createAssembler() const override {
+ return nullptr;
+ }
static FixupKind getPcRelFixup() { return PcRelFixup; }
static FixupKind getAbsFixup() { return AbsFixup; }
@@ -353,10 +356,17 @@ protected:
}
/// Emit just the call instruction (without argument or return variable
/// processing), sandboxing if needed.
- virtual Inst *emitCallToTarget(Operand *CallTarget, Variable *ReturnReg) = 0;
+ virtual Inst *emitCallToTarget(Operand *CallTarget, Variable *ReturnReg) {
+ (void)CallTarget;
+ (void)ReturnReg;
+ return nullptr;
+ }
/// Materialize the moves needed to return a value of the specified type.
- virtual Variable *moveReturnValueToRegister(Operand *Value,
- Type ReturnType) = 0;
+ virtual Variable *moveReturnValueToRegister(Operand *Value, Type ReturnType) {
+ (void)Value;
+ (void)ReturnType;
+ return nullptr;
+ }
/// Emit a jump table to the constant pool.
void emitJumpTable(const Cfg *Func,
« no previous file with comments | « Makefile.standalone ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698