Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1778623002: DDC: remove dumpInfo flag (Closed)

Created:
4 years, 9 months ago by Jennifer Messerly
Modified:
4 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DDC: remove dumpInfo flag I was hoping to get rid of SummaryReporter altogether, but it looks like it's still used by server mode. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/ab56d4cda9ee8bbdc36f00f92783ccbbae17e82c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -221 lines) Patch
D bin/edit_files.dart View 1 chunk +0 lines, -166 lines 0 comments Download
M lib/src/closure/closure_type.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/codegen/js_metalet.dart View 3 chunks +14 lines, -7 lines 0 comments Download
M lib/src/codegen/side_effect_analysis.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/compiler.dart View 3 chunks +2 lines, -7 lines 0 comments Download
M lib/src/options.dart View 4 chunks +0 lines, -14 lines 0 comments Download
M lib/src/server/server.dart View 2 chunks +10 lines, -11 lines 0 comments Download
M lib/src/transformer/asset_source.dart View 1 chunk +2 lines, -1 line 0 comments Download
M test/codegen_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tool/patch_sdk.dart View 5 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jennifer Messerly
4 years, 9 months ago (2016-03-08 19:19:39 UTC) #3
vsm
leaf - are you using this at all? I think this is the info-summary generated ...
4 years, 9 months ago (2016-03-08 23:22:07 UTC) #4
Leaf
On 2016/03/08 23:22:07, vsm wrote: > leaf - are you using this at all? > ...
4 years, 9 months ago (2016-03-08 23:24:58 UTC) #5
vsm
lgtm
4 years, 9 months ago (2016-03-08 23:25:53 UTC) #6
Jennifer Messerly
4 years, 9 months ago (2016-03-08 23:47:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab56d4cda9ee8bbdc36f00f92783ccbbae17e82c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698