lib/src/codegen/side_effect_analysis.dart - Issue 1778623002: DDC: remove dumpInfo flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/side_effect_analysis.dart

Issue 1778623002: DDC: remove dumpInfo flag (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/side_effect_analysis.dart

diff --git a/lib/src/codegen/side_effect_analysis.dart b/lib/src/codegen/side_effect_analysis.dart

index 9b58c653d2324dce72a1f1f2eafcecbcdd1ebd2e..92b4ac8f280f73fb89851a3e3b619ffd5a4b9013 100644

--- a/lib/src/codegen/side_effect_analysis.dart

+++ b/lib/src/codegen/side_effect_analysis.dart

@@ -51,7 +51,8 @@ bool isStateless(FunctionBody function, Expression node, [AstNode context]) {

/// Returns true if the local variable is potentially mutated within [context].

/// This accounts for closures that may have been created outside of [context].

-bool _isPotentiallyMutated(FunctionBody function, VariableElement e, [AstNode context]) {

+bool _isPotentiallyMutated(FunctionBody function, VariableElement e,

+ [AstNode context]) {

if (function.isPotentiallyMutatedInClosure(e)) return true;

if (function.isPotentiallyMutatedInScope(e)) {

// Need to visit the context looking for assignment to this local.

« no previous file with comments | « lib/src/codegen/js_metalet.dart ('k') | lib/src/compiler.dart » ('j') | no next file with comments »