Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1778593003: Mozart: Add helpers for building view associates. (Closed)

Created:
4 years, 9 months ago by jeffbrown
Modified:
4 years, 9 months ago
Reviewers:
abarth
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@moz-6
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mozart: Add helpers for building view associates. Created helpers for hit testing and resolving scenes to views including unit tests. BUG= R=abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c64f0d456d50a0e7b8169af82d76379c0cc8bf6b

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1121 lines, -0 lines) Patch
M mojo/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A mojo/ui/associates/BUILD.gn View 1 chunk +71 lines, -0 lines 0 comments Download
A mojo/ui/associates/mock_hit_tester.h View 1 chunk +39 lines, -0 lines 0 comments Download
A mojo/ui/associates/mock_hit_tester.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A mojo/ui/associates/mock_view_inspector.h View 1 chunk +67 lines, -0 lines 0 comments Download
A mojo/ui/associates/mock_view_inspector.cc View 1 chunk +92 lines, -0 lines 0 comments Download
A mojo/ui/associates/resolved_hits.h View 1 chunk +65 lines, -0 lines 0 comments Download
A mojo/ui/associates/resolved_hits.cc View 1 chunk +56 lines, -0 lines 0 comments Download
A mojo/ui/associates/test_helpers.h View 1 1 chunk +67 lines, -0 lines 0 comments Download
A mojo/ui/associates/view_inspector_client.h View 1 1 chunk +59 lines, -0 lines 0 comments Download
A mojo/ui/associates/view_inspector_client.cc View 1 chunk +111 lines, -0 lines 0 comments Download
A mojo/ui/associates/view_inspector_client_apptest.cc View 1 1 chunk +149 lines, -0 lines 0 comments Download
A mojo/ui/associates/view_tree_hit_tester_client.h View 1 chunk +65 lines, -0 lines 0 comments Download
A mojo/ui/associates/view_tree_hit_tester_client.cc View 1 chunk +92 lines, -0 lines 0 comments Download
A mojo/ui/associates/view_tree_hit_tester_client_apptest.cc View 1 1 chunk +148 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1774393002 Patch 20001

Dependent Patchsets:

Issue 1776473005 Patch 20001

Messages

Total messages: 6 (2 generated)
jeffbrown
4 years, 9 months ago (2016-03-09 02:21:56 UTC) #2
abarth
lgtm https://codereview.chromium.org/1778593003/diff/1/mojo/ui/associates/test_helpers.h File mojo/ui/associates/test_helpers.h (right): https://codereview.chromium.org/1778593003/diff/1/mojo/ui/associates/test_helpers.h#newcode26 mojo/ui/associates/test_helpers.h:26: } These are pretty general functions. They're not ...
4 years, 9 months ago (2016-03-09 04:06:36 UTC) #3
jeffbrown
https://codereview.chromium.org/1778593003/diff/1/mojo/ui/associates/test_helpers.h File mojo/ui/associates/test_helpers.h (right): https://codereview.chromium.org/1778593003/diff/1/mojo/ui/associates/test_helpers.h#newcode26 mojo/ui/associates/test_helpers.h:26: } On 2016/03/09 04:06:36, abarth wrote: > These are ...
4 years, 9 months ago (2016-03-09 19:43:43 UTC) #4
jeffbrown
4 years, 9 months ago (2016-03-09 22:23:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c64f0d456d50a0e7b8169af82d76379c0cc8bf6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698