Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1774393002: Mozart: Add ViewInspector contracts for hit testing. (Closed)

Created:
4 years, 9 months ago by jeffbrown
Modified:
4 years, 9 months ago
Reviewers:
abarth
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@moz-5
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mozart: Add ViewInspector contracts for hit testing. Allow ViewAssociates to perform hit testing on the rendered scene graph and to map scene tokens to view tokens as required. Rather than force an extra round-trip through the ViewManager for each hit test, this contract is designed to allow the client to cache the scene token to view token mapping locally. BUG= R=abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/59cd2e422c963c6f1f577893e294a7a8902eb5b9

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+579 lines, -10 lines) Patch
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_associates.mojom.dart View 1 8 chunks +454 lines, -1 line 0 comments Download
M mojo/services/ui/views/interfaces/view_associates.mojom View 2 chunks +24 lines, -0 lines 0 comments Download
M services/ui/view_manager/view_registry.h View 2 chunks +12 lines, -0 lines 0 comments Download
M services/ui/view_manager/view_registry.cc View 7 chunks +51 lines, -5 lines 0 comments Download
M services/ui/view_manager/view_tree_state.h View 3 chunks +14 lines, -3 lines 0 comments Download
M services/ui/view_manager/view_tree_state.cc View 1 chunk +24 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
jeffbrown
4 years, 9 months ago (2016-03-09 02:24:17 UTC) #2
abarth
lgtm
4 years, 9 months ago (2016-03-09 04:19:16 UTC) #3
jeffbrown
4 years, 9 months ago (2016-03-09 22:23:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
59cd2e422c963c6f1f577893e294a7a8902eb5b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698