Issue 1778423002: Don't upload "null" to the Sync server for empty federation_url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1778423002: Don't upload "null" to the Sync server for empty federation_url. (Closed)

Created:
4 years, 9 months ago by vasilii

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

Don't upload "null" to the Sync server for empty federation_url. BUG=593380 Review URL: https://codereview.chromium.org/1780683002 Cr-Commit-Position: refs/heads/master@{#380164} (cherry picked from commit c1e26c7b4a6f7d692312f4de15996e33b1c10a90) Committed: https://chromium.googlesource.com/chromium/src/+/daaf129eb29d09495b47506e75f0ffce217b5979

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -6 lines)			Patch
M	components/password_manager/core/browser/login_database.cc	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	components/password_manager/core/browser/password_syncable_service.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	components/password_manager/core/browser/password_syncable_service_unittest.cc	View	1 chunk	+23 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

vasilii

4 years, 9 months ago (2016-03-10 18:30:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
daaf129eb29d09495b47506e75f0ffce217b5979.