Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1780683002: Don't upload "null" to the Sync server for empty federation_url. (Closed)

Created:
4 years, 9 months ago by vasilii
Modified:
4 years, 9 months ago
Reviewers:
markusheintz_, engedy
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't upload "null" to the Sync server for empty federation_url. BUG=593380 Committed: https://crrev.com/c1e26c7b4a6f7d692312f4de15996e33b1c10a90 Cr-Commit-Position: refs/heads/master@{#380164}

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M components/password_manager/core/browser/login_database.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/password_syncable_service.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/password_syncable_service_unittest.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
vasilii
Hi, please review.
4 years, 9 months ago (2016-03-09 17:44:07 UTC) #2
vasilii
Markus, PTAL
4 years, 9 months ago (2016-03-09 17:50:01 UTC) #4
markusheintz_
LGTM https://codereview.chromium.org/1780683002/diff/1/components/password_manager/core/browser/login_database.cc File components/password_manager/core/browser/login_database.cc (right): https://codereview.chromium.org/1780683002/diff/1/components/password_manager/core/browser/login_database.cc#newcode145 components/password_manager/core/browser/login_database.cc:145: form.federation_origin.unique() opt: Add acomment describing why or simply ...
4 years, 9 months ago (2016-03-09 18:03:00 UTC) #5
markusheintz_
https://codereview.chromium.org/1780683002/diff/1/components/password_manager/core/browser/password_syncable_service_unittest.cc File components/password_manager/core/browser/password_syncable_service_unittest.cc (right): https://codereview.chromium.org/1780683002/diff/1/components/password_manager/core/browser/password_syncable_service_unittest.cc#newcode603 components/password_manager/core/browser/password_syncable_service_unittest.cc:603: // Make sure that the Origins uploaded incorrectly are ...
4 years, 9 months ago (2016-03-09 18:05:50 UTC) #6
vasilii
https://codereview.chromium.org/1780683002/diff/1/components/password_manager/core/browser/login_database.cc File components/password_manager/core/browser/login_database.cc (right): https://codereview.chromium.org/1780683002/diff/1/components/password_manager/core/browser/login_database.cc#newcode145 components/password_manager/core/browser/login_database.cc:145: form.federation_origin.unique() On 2016/03/09 18:02:59, markusheintz_ wrote: > opt: Add ...
4 years, 9 months ago (2016-03-09 18:11:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780683002/20001
4 years, 9 months ago (2016-03-09 18:11:38 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 18:55:57 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 18:57:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c1e26c7b4a6f7d692312f4de15996e33b1c10a90
Cr-Commit-Position: refs/heads/master@{#380164}

Powered by Google App Engine
This is Rietveld 408576698