Don't upload "null" to the Sync server for empty federation_url.

Don't upload "null" to the Sync server for empty federation_url.

BUG=593380
Committed: https://crrev.com/c1e26c7b4a6f7d692312f4de15996e33b1c10a90
Cr-Commit-Position: refs/heads/master@{#380164}

[vasilii, 2016-03-09 17:44:07]

vasilii@chromium.org changed reviewers:
+ engedy@chromium.org

[vasilii, 2016-03-09 17:44:07]

Hi,

please review.

[vasilii, 2016-03-09 17:50:01]

vasilii@chromium.org changed reviewers:
+ markusheintz@chromium.org

[vasilii, 2016-03-09 17:50:01]

Markus, PTAL

[markusheintz_, 2016-03-09 18:03:00]

LGTM

https://codereview.chromium.org/1780683002/diff/1/components/password_manager...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/1780683002/diff/1/components/password_manager...
components/password_manager/core/browser/login_database.cc:145:
form.federation_origin.unique()
opt: Add acomment describing why or simply referencing the bug.

[markusheintz_, 2016-03-09 18:05:50]

https://codereview.chromium.org/1780683002/diff/1/components/password_manager...
File
components/password_manager/core/browser/password_syncable_service_unittest.cc
(right):

https://codereview.chromium.org/1780683002/diff/1/components/password_manager...
components/password_manager/core/browser/password_syncable_service_unittest.cc:603:
// Make sure that the Origins uploaded incorrectly are still dwonloaded
typo: downloaded

nit: They are not downloaded correctly but correctly deserialize.

[vasilii, 2016-03-09 18:11:20]

https://codereview.chromium.org/1780683002/diff/1/components/password_manager...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/1780683002/diff/1/components/password_manager...
components/password_manager/core/browser/login_database.cc:145:
form.federation_origin.unique()
On 2016/03/09 18:02:59, markusheintz_ wrote:
> opt: Add acomment describing why or simply referencing the bug.

Done.

https://codereview.chromium.org/1780683002/diff/1/components/password_manager...
File
components/password_manager/core/browser/password_syncable_service_unittest.cc
(right):

https://codereview.chromium.org/1780683002/diff/1/components/password_manager...
components/password_manager/core/browser/password_syncable_service_unittest.cc:603:
// Make sure that the Origins uploaded incorrectly are still dwonloaded
On 2016/03/09 18:05:50, markusheintz_ wrote:
> typo: downloaded
> 
> nit: They are not downloaded correctly but correctly deserialize.

Done.

[vasilii, 2016-03-09 18:11:26]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2016-03-09 18:11:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
markusheintz@chromium.org
Link to the patchset: https://codereview.chromium.org/1780683002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2016-03-09 18:11:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780683002/20001

[commit-bot: I haz the power, 2016-03-09 18:55:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-09 18:57:23]

Description was changed from

==========
Don't upload "null" to the Sync server for empty federation_url.

BUG=593380
==========

to

==========
Don't upload "null" to the Sync server for empty federation_url.

BUG=593380

Committed: https://crrev.com/c1e26c7b4a6f7d692312f4de15996e33b1c10a90
Cr-Commit-Position: refs/heads/master@{#380164}
==========

[commit-bot: I haz the power, 2016-03-09 18:57:24]

Patchset 2 (id:??) landed as
https://crrev.com/c1e26c7b4a6f7d692312f4de15996e33b1c10a90
Cr-Commit-Position: refs/heads/master@{#380164}