include/core/SkShader.h - Issue 1778393002: add Make variations to return SkImage by sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkShader.h

Issue 1778393002: add Make variations to return SkImage by sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: roll in fmalitas comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkShader.h

diff --git a/include/core/SkShader.h b/include/core/SkShader.h

index 3e4093645cc2f6ddc301171fc1021f0978293b1a..8b441273b4f0f6bcf83ce6c8c0254187c85c1a5c 100644

--- a/include/core/SkShader.h

+++ b/include/core/SkShader.h

@@ -404,7 +404,7 @@ public:

* bounds.

* @return Returns a new shader object. Note: this function never returns null.

- static sk_sp<SkShader> MakePictureShader(sk_sp<const SkPicture> src, TileMode tmx, TileMode tmy,

+ static sk_sp<SkShader> MakePictureShader(sk_sp<SkPicture> src, TileMode tmx, TileMode tmy,

const SkMatrix* localMatrix, const SkRect* tile);

/**