Stop printing LOG(ERROR) when NFC service is unknown

Stop printing LOG(ERROR) when NFC service is unknown

Add a new callback method to NfcPropertySet and let it own its WeakPtrFactory.
Check the error name to reduce LOG(ERROR) noise.

BUG=393311
TEST=Boot a Chromebook (link) and "grep neard /var/log/ui/ui.LATEST" to
see nothing.

Committed: https://crrev.com/0ec21794e4e82b2b88f7a6b7fce48c0e47a442ef
Cr-Commit-Position: refs/heads/master@{#383025}

[hashimoto, 2016-03-10 05:58:14]

Description was changed from

==========
Stop printing LOG(ERROR) when NFC service is unknown

BUG=393311
TEST=Boot a Chromebook (link) and "grep neard /var/log/ui/ui.LATEST" to
see nothing.
==========

to

==========
Stop printing LOG(ERROR) when NFC service is unknown

Add a new callback method to NfcPropertySet and let it own its WeakPtrFactory.
Check the error name to reduce LOG(ERROR) noise.

BUG=393311
TEST=Boot a Chromebook (link) and "grep neard /var/log/ui/ui.LATEST" to
see nothing.
==========

[hashimoto, 2016-03-10 05:59:45]

hashimoto@chromium.org changed reviewers:
+ armansito@chromium.org

[hashimoto, 2016-03-17 11:19:08]

Arman, could you take a look at this change?

[hashimoto, 2016-03-22 04:47:08]

hashimoto@chromium.org changed reviewers:
+ stevenjb@chromium.org

[hashimoto, 2016-03-22 04:47:08]

Steven, could you take a look at this change?

[stevenjb, 2016-03-22 16:17:51]

Thanks for doing this!

https://codereview.chromium.org/1778273002/diff/20001/chromeos/dbus/nfc_prope...
File chromeos/dbus/nfc_property_set.h (right):

https://codereview.chromium.org/1778273002/diff/20001/chromeos/dbus/nfc_prope...
chromeos/dbus/nfc_property_set.h:54: base::WeakPtrFactory<NfcPropertySet>
weak_ptr_factory_;
Instead of adding a second WeakPtrFactory to protect the callback, call 
weak_ptr_factory_.InvalidateWeakPtrs() in the NfcPropertySet destructor. (You'll
need to expose that in dbus::PropertySet).

[hashimoto, 2016-03-23 03:27:03]

https://codereview.chromium.org/1778273002/diff/20001/chromeos/dbus/nfc_prope...
File chromeos/dbus/nfc_property_set.h (right):

https://codereview.chromium.org/1778273002/diff/20001/chromeos/dbus/nfc_prope...
chromeos/dbus/nfc_property_set.h:54: base::WeakPtrFactory<NfcPropertySet>
weak_ptr_factory_;
On 2016/03/22 16:17:51, stevenjb wrote:
> Instead of adding a second WeakPtrFactory to protect the callback, call 
> weak_ptr_factory_.InvalidateWeakPtrs() in the NfcPropertySet destructor.
(You'll
> need to expose that in dbus::PropertySet).

This WeakPtrFactory is needed to make a callback of OnGetAllError which requires
WeakPtr<NfcPropertySet>, instead of WeakPtr<dbus::PropertySet>.

[stevenjb, 2016-03-23 04:03:33]

lgtm

https://codereview.chromium.org/1778273002/diff/20001/chromeos/dbus/nfc_prope...
File chromeos/dbus/nfc_property_set.h (right):

https://codereview.chromium.org/1778273002/diff/20001/chromeos/dbus/nfc_prope...
chromeos/dbus/nfc_property_set.h:54: base::WeakPtrFactory<NfcPropertySet>
weak_ptr_factory_;
On 2016/03/23 03:27:03, hashimoto wrote:
> On 2016/03/22 16:17:51, stevenjb wrote:
> > Instead of adding a second WeakPtrFactory to protect the callback, call 
> > weak_ptr_factory_.InvalidateWeakPtrs() in the NfcPropertySet destructor.
> (You'll
> > need to expose that in dbus::PropertySet).
> 
> This WeakPtrFactory is needed to make a callback of OnGetAllError which
requires
> WeakPtr<NfcPropertySet>, instead of WeakPtr<dbus::PropertySet>.

Ugh. I see. Fair enough.

[hashimoto, 2016-03-24 03:15:23]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2016-03-24 03:15:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778273002/20001

[commit-bot: I haz the power, 2016-03-24 03:54:26]

Description was changed from

==========
Stop printing LOG(ERROR) when NFC service is unknown

Add a new callback method to NfcPropertySet and let it own its WeakPtrFactory.
Check the error name to reduce LOG(ERROR) noise.

BUG=393311
TEST=Boot a Chromebook (link) and "grep neard /var/log/ui/ui.LATEST" to
see nothing.
==========

to

==========
Stop printing LOG(ERROR) when NFC service is unknown

Add a new callback method to NfcPropertySet and let it own its WeakPtrFactory.
Check the error name to reduce LOG(ERROR) noise.

BUG=393311
TEST=Boot a Chromebook (link) and "grep neard /var/log/ui/ui.LATEST" to
see nothing.
==========

[commit-bot: I haz the power, 2016-03-24 03:54:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-24 03:55:47]

Description was changed from

==========
Stop printing LOG(ERROR) when NFC service is unknown

Add a new callback method to NfcPropertySet and let it own its WeakPtrFactory.
Check the error name to reduce LOG(ERROR) noise.

BUG=393311
TEST=Boot a Chromebook (link) and "grep neard /var/log/ui/ui.LATEST" to
see nothing.
==========

to

==========
Stop printing LOG(ERROR) when NFC service is unknown

Add a new callback method to NfcPropertySet and let it own its WeakPtrFactory.
Check the error name to reduce LOG(ERROR) noise.

BUG=393311
TEST=Boot a Chromebook (link) and "grep neard /var/log/ui/ui.LATEST" to
see nothing.

Committed: https://crrev.com/0ec21794e4e82b2b88f7a6b7fce48c0e47a442ef
Cr-Commit-Position: refs/heads/master@{#383025}
==========

[commit-bot: I haz the power, 2016-03-24 03:55:49]

Patchset 2 (id:??) landed as
https://crrev.com/0ec21794e4e82b2b88f7a6b7fce48c0e47a442ef
Cr-Commit-Position: refs/heads/master@{#383025}