Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: chromeos/dbus/nfc_property_set.h

Issue 1778273002: Stop printing LOG(ERROR) when NFC service is unknown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/nfc_client_unittest.cc ('k') | chromeos/dbus/nfc_property_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/nfc_property_set.h
diff --git a/chromeos/dbus/nfc_property_set.h b/chromeos/dbus/nfc_property_set.h
index ee18528280b8074657f7f2403b1ed4958b77104b..4b5016ad759ea65b7044aa20b7debfdd37925962 100644
--- a/chromeos/dbus/nfc_property_set.h
+++ b/chromeos/dbus/nfc_property_set.h
@@ -45,10 +45,14 @@ class NfcPropertySet : public dbus::PropertySet {
const base::Closure& on_get_all_callback() { return on_get_all_callback_; }
private:
+ void OnGetAllError(dbus::ErrorResponse* response);
+
// Optional callback used to notify clients when all properties were received
// after a call to GetAll.
base::Closure on_get_all_callback_;
+ base::WeakPtrFactory<NfcPropertySet> weak_ptr_factory_;
stevenjb 2016/03/22 16:17:51 Instead of adding a second WeakPtrFactory to prote
hashimoto 2016/03/23 03:27:03 This WeakPtrFactory is needed to make a callback o
stevenjb 2016/03/23 04:03:33 Ugh. I see. Fair enough.
+
DISALLOW_COPY_AND_ASSIGN(NfcPropertySet);
};
« no previous file with comments | « chromeos/dbus/nfc_client_unittest.cc ('k') | chromeos/dbus/nfc_property_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698