Issue 1778213003: UI Compositor: Fix threaded animation survival if layer removed and added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1778213003: UI Compositor: Fix threaded animation survival if layer removed and added. (Closed)

Created:
4 years, 9 months ago by loyso (OOO)

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

UI Compositor: Fix threaded animation survival if layer removed and added. This is minimal fix, scoped in ui/compositor. To be merged. In general, we must allow to move AnimationPlayers between timelines inside same Compositor(AnimationHost) without any animation losses. See http://crbug.com/592873 (To be designed separately) BUG=591474 Review URL: https://codereview.chromium.org/1776513002 Cr-Commit-Position: refs/heads/master@{#380047} (cherry picked from commit 3338dfbd7f61e4ebb5a1e1519e0ef930cd7499d8) Committed: https://chromium.googlesource.com/chromium/src/+/aacac20280640e01e261b003078041e211f250dc

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -1 line)			Patch
M	ui/compositor/layer_animator.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	ui/compositor/layer_animator.cc	View	3 chunks	+28 lines, -1 line	0 comments	Download
M	ui/compositor/layer_animator_unittest.cc	View	1 chunk	+35 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

loyso (OOO)

4 years, 9 months ago (2016-03-10 04:13:55 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aacac20280640e01e261b003078041e211f250dc.