[Findit] Strip platform from step_name before triggering try job.

appengine/findit/waterfall/try_job_util.py

Index: appengine/findit/waterfall/try_job_util.py
diff --git a/appengine/findit/waterfall/try_job_util.py b/appengine/findit/waterfall/try_job_util.py
index 738c9f197b04544868ed28dd02e2cb56a7c1eeea..e287e394248898d86ac18044061459eee6871cb4 100644
--- a/appengine/findit/waterfall/try_job_util.py
+++ b/appengine/findit/waterfall/try_job_util.py
@@ -79,6 +79,17 @@ def _CheckIfNeedNewTryJobForTestFailure(
   return targeted_tests, need_new_try_job, last_pass
 
 
+def _StripPlatform(targeted_tests):

[lijeffrey, 2016/03/10 00:43:56]

nit: just for clarity maybe rename this '_GetTargetedTestsWithoutPlatform' or
something similar and add a doc string

[chanli, 2016/03/10 23:31:51]

Function deleted.

+  if not targeted_tests:
+    return None
+
+  updated_tests = {}
+  for step_name, tests in targeted_tests.iteritems():
+    updated_tests[step_name.strip()[0]] = tests

[stgao, 2016/03/10 00:39:30]

How about using the value of tag "name" in the Swarming tasks instead?

IIRC, we already pull information from Swarming Server for the whole build to
determine which steps are run on Swarming.
For those not running on Swarming, just default to the step name from build json
data.

https://apis-explorer.appspot.com/apis-explorer/?base=https://chromium-swarm....

[lijeffrey, 2016/03/10 00:43:56]

are you sure you want step_name.strip()[0]? I think that only gives you the
first letter?

[chanli, 2016/03/10 23:31:51]

Right... I wanted to use split... Done

[chanli, 2016/03/10 23:31:51]

You're right, and actually this patch won't work because it just modified
original target_tests but not the updated_one.

+
+  return updated_tests
+
+
 @ndb.transactional
 def _NeedANewTryJob(
     master_name, builder_name, build_number, failed_steps, failure_result_map):
@@ -114,6 +125,8 @@ def _NeedANewTryJob(
           master_name, builder_name, build_number)
       try_job.put()
 
+  targeted_tests = _StripPlatform(targeted_tests)
+
   return need_new_try_job, last_pass, try_job_type, targeted_tests